You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/11/07 23:48:47 UTC
Review Request 63650: Display pending task reasons in TaskList
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63650/
-----------------------------------------------------------
Review request for Aurora, Kai Huang and Reza Motamedi.
Repository: aurora
Description
-------
Add reasons to pending tasks
Diffs
-----
ui/src/main/js/components/JobHistory.js 7eff462777deb05c494399f7accc8b703417a447
ui/src/main/js/components/JobStatus.js 8f7023beda21f4c0ba8952b4df13ac80841e8750
ui/src/main/js/components/TaskList.js c0815cfea05e4669083e53660aef52f4221c9cc2
ui/src/main/js/components/__tests__/TaskList-test.js 948e86bd9f44380308bbd4bff9a254708545953c
ui/src/main/js/pages/Job.js 2f96e23008603ca1bc61b9cc80967e3efedb0fbf
ui/src/main/js/test-utils/TaskBuilders.js f2b06451eb601e5c52a0902eeb29152ee39926b0
Diff: https://reviews.apache.org/r/63650/diff/1/
Testing
-------
./gradlew ui:lint
./gradlew ui:test
File Attachments
----------------
Pending reasons in UI
https://reviews.apache.org/media/uploaded/files/2017/11/07/43c3dc08-76e8-48c2-a0a9-1e8cf90d8e1d__Screen_Shot_2017-11-07_at_3.45.03_PM.png
Thanks,
David McLaughlin
Re: Review Request 63650: Display pending task reasons in TaskList
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63650/#review190395
-----------------------------------------------------------
Ship it!
Master (ad86177) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 7, 2017, 11:48 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63650/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 11:48 p.m.)
>
>
> Review request for Aurora, Kai Huang and Reza Motamedi.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add reasons to pending tasks
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js 7eff462777deb05c494399f7accc8b703417a447
> ui/src/main/js/components/JobStatus.js 8f7023beda21f4c0ba8952b4df13ac80841e8750
> ui/src/main/js/components/TaskList.js c0815cfea05e4669083e53660aef52f4221c9cc2
> ui/src/main/js/components/__tests__/TaskList-test.js 948e86bd9f44380308bbd4bff9a254708545953c
> ui/src/main/js/pages/Job.js 2f96e23008603ca1bc61b9cc80967e3efedb0fbf
> ui/src/main/js/test-utils/TaskBuilders.js f2b06451eb601e5c52a0902eeb29152ee39926b0
>
>
> Diff: https://reviews.apache.org/r/63650/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> File Attachments
> ----------------
>
> Pending reasons in UI
> https://reviews.apache.org/media/uploaded/files/2017/11/07/43c3dc08-76e8-48c2-a0a9-1e8cf90d8e1d__Screen_Shot_2017-11-07_at_3.45.03_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63650: Display pending task reasons in TaskList
Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63650/#review190399
-----------------------------------------------------------
Ship it!
Ship It!
- Kai Huang
On Nov. 7, 2017, 11:48 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63650/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 11:48 p.m.)
>
>
> Review request for Aurora, Kai Huang and Reza Motamedi.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add reasons to pending tasks
>
>
> Diffs
> -----
>
> ui/src/main/js/components/JobHistory.js 7eff462777deb05c494399f7accc8b703417a447
> ui/src/main/js/components/JobStatus.js 8f7023beda21f4c0ba8952b4df13ac80841e8750
> ui/src/main/js/components/TaskList.js c0815cfea05e4669083e53660aef52f4221c9cc2
> ui/src/main/js/components/__tests__/TaskList-test.js 948e86bd9f44380308bbd4bff9a254708545953c
> ui/src/main/js/pages/Job.js 2f96e23008603ca1bc61b9cc80967e3efedb0fbf
> ui/src/main/js/test-utils/TaskBuilders.js f2b06451eb601e5c52a0902eeb29152ee39926b0
>
>
> Diff: https://reviews.apache.org/r/63650/diff/1/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> File Attachments
> ----------------
>
> Pending reasons in UI
> https://reviews.apache.org/media/uploaded/files/2017/11/07/43c3dc08-76e8-48c2-a0a9-1e8cf90d8e1d__Screen_Shot_2017-11-07_at_3.45.03_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>