You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/27 18:02:15 UTC

[GitHub] mistercrunch commented on a change in pull request #6445: fix Calendar Heatmap

mistercrunch commented on a change in pull request #6445: fix Calendar Heatmap
URL: https://github.com/apache/incubator-superset/pull/6445#discussion_r236780762
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -790,7 +790,7 @@ def get_data(self, df):
         records = df.to_dict('records')
         for metric in self.metric_labels:
             data[metric] = {
-                str(obj[DTTM_ALIAS] / 10**9): obj.get(metric)
+                str(obj[DTTM_ALIAS].value / 10**9): obj.get(metric)
 
 Review comment:
   I feel like we've been going back and forth with the `.value` here. Maybe it flickers based on the pandas version? Are you on `0.23.1` ? It was last changed on this commit: 7b3095d6

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org