You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/30 09:41:39 UTC

[GitHub] [airflow] BasPH commented on pull request #9068: Make airflow/macros/hive.py Pylint compatible

BasPH commented on pull request #9068:
URL: https://github.com/apache/airflow/pull/9068#issuecomment-636306346


   Hi @potiuk, I took a closer look at what these 3 functions actually do. I get the feeling they were added to Airflow a long time ago without much thought about consistency and general usability for others. There are 3 functions:
   
   - `max_partition`: not used anywhere
   - `_closest_date`: "internal" function, used only in `closest_ds_partition` (same module)
   - `closest_ds_partition`:  not used anywhere
   
   To me the implementation of these 3 seem oddly specific to somebodies personal use case, so after closer inspection I'd opt for simply removing them from the codebase. I'll close this PR, and make another one doing that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org