You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/26 05:21:18 UTC

[GitHub] [helix] pkuwm commented on issue #911: Fix TestZNRecordSerializeWriteSizeLimit

pkuwm commented on issue #911: Fix TestZNRecordSerializeWriteSizeLimit
URL: https://github.com/apache/helix/pull/911#issuecomment-604235542
 
 
   This PR is ready to be merged, approved by @narendly 
   ```
   There was a exception type change in znrecord serializers: ZkClientException -> ZkMarshallingError. So the exception types don't match in the unit test.
   
   This commit fixes the issue by changing the expected exception type in the unit test.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org