You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/08 12:06:56 UTC
[GitHub] [superset] reesercollins commented on pull request #20290: fix: Faulty datetime parser regex
reesercollins commented on PR #20290:
URL: https://github.com/apache/superset/pull/20290#issuecomment-1149828865
This may just be our organization's changes to the dateparser which added a third option to the datetimeConstant regex which meant `now` would be parsed anywhere in the string, including in the string `DATEADD(DATETIME("now"), -7, day)`. Either way, by making this fix, it prevents further errors down the line should more datetime constants be added upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org