[GitHub] [netbeans] jGauravGupta commented on pull request #5847: Support for transformation from jakartaee8 to jakartaee10 applications

["jGauravGupta (via GitHub)" <gi...@apache.org>]

jGauravGupta commented on PR #5847:
URL: https://github.com/apache/netbeans/pull/5847#issuecomment-1613681216

   Hi @breakponchito,
   
   I have reviewed the code and it looks good to me. There are two improvements that I suggest:
   
   - Bind an event to the `source` and `target` text fields: Currently, there is a warning message displayed when a path is added directly in the text field. To improve this, you can bind an event to the text fields so that the warning message is automatically removed when a path is added directly into the text fields instead of using the browse button.
   
   - Remove the package goal from the execution command: It seems that the execution command is invoking the `maven-war-plugin` unnecessarily. To optimize the command, you can remove the package goal, as it may not be required for your specific use case. This will help streamline the execution process and remove any unnecessary steps.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists