You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/08/11 07:50:21 UTC
[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #2482: HIVE-25334: refactor timestamp UDF
ashish-kumar-sharma commented on a change in pull request #2482:
URL: https://github.com/apache/hive/pull/2482#discussion_r686585429
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java
##########
@@ -434,10 +434,19 @@ protected void obtainTimestampConverter(ObjectInspector[] arguments, int i,
case TIMESTAMP:
case DATE:
case TIMESTAMPLOCALTZ:
+ case INT:
Review comment:
There data are already implemented in https://github.com/apache/hive/blob/7b3ecf617a6d46f48a3b6f77e0339fd4ad95a420/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java#L1177. I am just adding validation check to avoid runtime failures. So no test is required in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org