You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/19 22:47:45 UTC
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11737: refactor: Replace react-bootstrap tooltips with Antd tooltips
rusackas commented on a change in pull request #11737:
URL: https://github.com/apache/incubator-superset/pull/11737#discussion_r527255370
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -484,17 +484,18 @@ a.Link {
margin: 3px 5px;
}
-.tooltip pre {
+.ant-tooltip pre {
Review comment:
would love to see these styles pulled into an Emotion styles in the component exported in /src/common/components
##########
File path: superset-frontend/src/SqlLab/main.less
##########
@@ -484,17 +484,18 @@ a.Link {
margin: 3px 5px;
}
-.tooltip pre {
+.ant-tooltip pre {
Review comment:
would love to see these styles pulled into an Emotion styles in the AntD component exported in /src/common/components
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org