[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #890: MINIFICPP-1288 - FlowController start/load refactor

[GitBox <gi...@apache.org>]

szaszm commented on pull request #890:
URL: https://github.com/apache/nifi-minifi-cpp/pull/890#issuecomment-688443647


   > I see what you mean, but I disagree. I would definitely avoid adding states like this to an object. I found it already quite a task to decipher in what state can we reach each of the member functions. How about either of these options:
   >     1. I can make the FlowController a state machine with well defined transitions between states
   >     2. I can add checks to the `start` method that ensure that the members set in `load` are indeed set.
   
   I don't really understand what you mean by making `FlowController` a state machine or checking members, but in either case, if you can make it hard or impossible to use `FlowController` incorrectly, that would be a big plus in my opinion.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org