[GitHub] [incubator-nuttx] patacongo commented on pull request #2857: boards: esp32: Set CONFIG_NET_ETH_PKTSIZE to 1514

[GitBox <gi...@apache.org>]

patacongo commented on pull request #2857:
URL: https://github.com/apache/incubator-nuttx/pull/2857#issuecomment-779587775


   This would probably break some minimal configurations.Sent from my Galaxy
   -------- Original message --------From: Masayuki Ishikawa <no...@github.com> Date: 2/15/21  11:03 PM  (GMT-06:00) To: apache/incubator-nuttx <in...@noreply.github.com> Cc: Subscribed <su...@noreply.github.com> Subject: Re: [apache/incubator-nuttx] boards: esp32: Set CONFIG_NET_ETH_PKTSIZE to 1514 (#2857) 
   
   Should we change NET_ETH_PKTSIZE default to 1514? Most people who hasn't the deep knowledge about NuttX network stack don't know the existence of NET_ETH_PKTSIZE config. The default value should work out of box in the most case to help the normal user.
   
   @xiaoxiang781216
   I agree with you.
   Should we close this issue and create a new PR for it?
   
   —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org