You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/29 05:03:11 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
HuangXingBo opened a new pull request #14800:
URL: https://github.com/apache/flink/pull/14800
## What is the purpose of the change
*This pull request will support setting namespace in RemoteKeyedStateBackend*
## Brief change log
- *add method `set_current_namespace` and `get_current_namespace` in `RemoteKeyedStateBackend`*
## Verifying this change
This change added tests and can be verified as follows:
- *original tests*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
}, {
"hash" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376",
"triggerID" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"triggerType" : "PUSH"
}, {
"hash" : "ece077ef0e4ba327f18de031a1b309dad82f34b4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14417",
"triggerID" : "ece077ef0e4ba327f18de031a1b309dad82f34b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad3797eb90c7c5d3e4b06827de7447e68a6991ff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376)
* ece077ef0e4ba327f18de031a1b309dad82f34b4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4c73b24c730472d974aa3d874e0a5c2e116ca51 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087)
* 0c8fa5d1aa21c6b98134ec528c8001b55d326b38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8e72b463e04f70c027be15507a7804779e9231 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825)
* d71b3928ea04131827c25a5b62d1ed7b954616ce UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
}, {
"hash" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376",
"triggerID" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"triggerType" : "PUSH"
}, {
"hash" : "ece077ef0e4ba327f18de031a1b309dad82f34b4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ece077ef0e4ba327f18de031a1b309dad82f34b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad3797eb90c7c5d3e4b06827de7447e68a6991ff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376)
* ece077ef0e4ba327f18de031a1b309dad82f34b4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e40eaab6964fa716a25cfe5dc82f63281cecff19 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e40eaab6964fa716a25cfe5dc82f63281cecff19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
}, {
"hash" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376",
"triggerID" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ad3797eb90c7c5d3e4b06827de7447e68a6991ff Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a change in pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #14800:
URL: https://github.com/apache/flink/pull/14800#discussion_r590152449
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -959,7 +1028,8 @@ def clear_cached_iterators(self):
@staticmethod
def commit_internal_state(internal_state):
- internal_state.commit()
+ if internal_state is not None:
+ internal_state.commit()
Review comment:
Yes, although `None` will not affect the execution of the following code, but adding the logic of `else return` can be cleaner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-794744089
@WeiZhong94 Thanks a lot for the review. I have rebased the `master` to resolve some conflics and addressed the comments at the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e40eaab6964fa716a25cfe5dc82f63281cecff19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635)
* 458410c347915582a9d223d0308c05d43396c995 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] WeiZhong94 commented on a change in pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on a change in pull request #14800:
URL: https://github.com/apache/flink/pull/14800#discussion_r590104166
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -80,59 +81,99 @@ def __iter__(self):
return iter(self._cache.values())
-class SynchronousValueRuntimeState(ValueState):
+class InternalKVState(object):
+ def __init__(self, name: str, remote_state_backend: 'RemoteKeyedStateBackend'):
+ self.name = name
+ self._remote_state_backend = remote_state_backend
+ self._internal_state = None
+ self.namespace = None
Review comment:
we can store the encoded namespace and only encoding at the first time.
##########
File path: flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/BeamPythonFunctionRunner.java
##########
@@ -543,12 +543,14 @@ private ExecutableStage createExecutableStage(RunnerApi.Environment environment)
private static StateRequestHandler getStateRequestHandler(
KeyedStateBackend keyedStateBackend,
TypeSerializer keySerializer,
+ TypeSerializer windowSerializer,
Review comment:
If we decide to rename `window_coder` to `namespace_coder` at python side, we also need to rename the `windowSerializer` here.
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -798,6 +857,11 @@ def __init__(self,
state_handler, map_state_read_cache_size)
from pyflink.fn_execution.coders import FlattenRowCoder
self._key_coder_impl = FlattenRowCoder(key_coder._field_coders).get_impl()
+ self.window_coder = window_coder
Review comment:
I think we do not need to store the window_coder because it is not used anywhere except the init method.
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -959,7 +1028,8 @@ def clear_cached_iterators(self):
@staticmethod
def commit_internal_state(internal_state):
- internal_state.commit()
+ if internal_state is not None:
+ internal_state.commit()
Review comment:
else return, the following code is also not need to be executed.
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -798,6 +857,11 @@ def __init__(self,
state_handler, map_state_read_cache_size)
from pyflink.fn_execution.coders import FlattenRowCoder
self._key_coder_impl = FlattenRowCoder(key_coder._field_coders).get_impl()
+ self.window_coder = window_coder
+ if window_coder:
Review comment:
It would be better if we rename it to `namespace_coder` and its implementation to `_namespace_coder_impl` to make the meaning clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d71b3928ea04131827c25a5b62d1ed7b954616ce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073)
* c4c73b24c730472d974aa3d874e0a5c2e116ca51 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 458410c347915582a9d223d0308c05d43396c995 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692)
* cc8e72b463e04f70c027be15507a7804779e9231 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769577218
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e40eaab6964fa716a25cfe5dc82f63281cecff19 (Fri Jan 29 05:05:41 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21192).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a change in pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #14800:
URL: https://github.com/apache/flink/pull/14800#discussion_r590152686
##########
File path: flink-python/src/main/java/org/apache/flink/streaming/api/runners/python/beam/BeamPythonFunctionRunner.java
##########
@@ -543,12 +543,14 @@ private ExecutableStage createExecutableStage(RunnerApi.Environment environment)
private static StateRequestHandler getStateRequestHandler(
KeyedStateBackend keyedStateBackend,
TypeSerializer keySerializer,
+ TypeSerializer windowSerializer,
Review comment:
Make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
}, {
"hash" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376",
"triggerID" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c8fa5d1aa21c6b98134ec528c8001b55d326b38 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366)
* ad3797eb90c7c5d3e4b06827de7447e68a6991ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e40eaab6964fa716a25cfe5dc82f63281cecff19 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635)
* 458410c347915582a9d223d0308c05d43396c995 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d71b3928ea04131827c25a5b62d1ed7b954616ce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
}, {
"hash" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4c73b24c730472d974aa3d874e0a5c2e116ca51 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087)
* 0c8fa5d1aa21c6b98134ec528c8001b55d326b38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366)
* ad3797eb90c7c5d3e4b06827de7447e68a6991ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d71b3928ea04131827c25a5b62d1ed7b954616ce Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073)
* c4c73b24c730472d974aa3d874e0a5c2e116ca51 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 458410c347915582a9d223d0308c05d43396c995 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e40eaab6964fa716a25cfe5dc82f63281cecff19 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4c73b24c730472d974aa3d874e0a5c2e116ca51 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087)
* 0c8fa5d1aa21c6b98134ec528c8001b55d326b38 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8e72b463e04f70c027be15507a7804779e9231 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825)
* d71b3928ea04131827c25a5b62d1ed7b954616ce Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo closed pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
HuangXingBo closed pull request #14800:
URL: https://github.com/apache/flink/pull/14800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 458410c347915582a9d223d0308c05d43396c995 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692)
* cc8e72b463e04f70c027be15507a7804779e9231 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a change in pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #14800:
URL: https://github.com/apache/flink/pull/14800#discussion_r590151026
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -798,6 +857,11 @@ def __init__(self,
state_handler, map_state_read_cache_size)
from pyflink.fn_execution.coders import FlattenRowCoder
self._key_coder_impl = FlattenRowCoder(key_coder._field_coders).get_impl()
+ self.window_coder = window_coder
Review comment:
Yes. This should actually be added in the follow-up PR, I will delete it first.
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -798,6 +857,11 @@ def __init__(self,
state_handler, map_state_read_cache_size)
from pyflink.fn_execution.coders import FlattenRowCoder
self._key_coder_impl = FlattenRowCoder(key_coder._field_coders).get_impl()
+ self.window_coder = window_coder
+ if window_coder:
Review comment:
Make senses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc8e72b463e04f70c027be15507a7804779e9231 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
}, {
"hash" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376",
"triggerID" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4c73b24c730472d974aa3d874e0a5c2e116ca51 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087)
* 0c8fa5d1aa21c6b98134ec528c8001b55d326b38 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366)
* ad3797eb90c7c5d3e4b06827de7447e68a6991ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
}, {
"hash" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14366",
"triggerID" : "0c8fa5d1aa21c6b98134ec528c8001b55d326b38",
"triggerType" : "PUSH"
}, {
"hash" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14376",
"triggerID" : "ad3797eb90c7c5d3e4b06827de7447e68a6991ff",
"triggerType" : "PUSH"
}, {
"hash" : "ece077ef0e4ba327f18de031a1b309dad82f34b4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14417",
"triggerID" : "ece077ef0e4ba327f18de031a1b309dad82f34b4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ece077ef0e4ba327f18de031a1b309dad82f34b4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14417)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14800:
URL: https://github.com/apache/flink/pull/14800#issuecomment-769581041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12635",
"triggerID" : "e40eaab6964fa716a25cfe5dc82f63281cecff19",
"triggerType" : "PUSH"
}, {
"hash" : "458410c347915582a9d223d0308c05d43396c995",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13692",
"triggerID" : "458410c347915582a9d223d0308c05d43396c995",
"triggerType" : "PUSH"
}, {
"hash" : "cc8e72b463e04f70c027be15507a7804779e9231",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13825",
"triggerID" : "cc8e72b463e04f70c027be15507a7804779e9231",
"triggerType" : "PUSH"
}, {
"hash" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14073",
"triggerID" : "d71b3928ea04131827c25a5b62d1ed7b954616ce",
"triggerType" : "PUSH"
}, {
"hash" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087",
"triggerID" : "c4c73b24c730472d974aa3d874e0a5c2e116ca51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4c73b24c730472d974aa3d874e0a5c2e116ca51 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14087)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] WeiZhong94 commented on a change in pull request #14800: [FLINK-21192][python] Support setting namespace in RemoteKeyedStateBackend
Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on a change in pull request #14800:
URL: https://github.com/apache/flink/pull/14800#discussion_r590104166
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -80,59 +81,99 @@ def __iter__(self):
return iter(self._cache.values())
-class SynchronousValueRuntimeState(ValueState):
+class InternalKVState(object):
+ def __init__(self, name: str, remote_state_backend: 'RemoteKeyedStateBackend'):
+ self.name = name
+ self._remote_state_backend = remote_state_backend
+ self._internal_state = None
+ self.namespace = None
Review comment:
we can store the encoded namespace and only encoding at the first time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org