[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5296: tcp: fixed ISO C89/C90 related warnings

[GitBox <gi...@apache.org>]

pkarashchenko commented on a change in pull request #5296:
URL: https://github.com/apache/incubator-nuttx/pull/5296#discussion_r789465654



##########
File path: net/tcp/tcp_recvfrom.c
##########
@@ -191,10 +191,10 @@ static inline uint16_t tcp_newdata(FAR struct net_driver_s *dev,
       if (nsaved < buflen)
         {
           nwarn("WARNING: packet data not fully saved "
-                "(%d/%u/%zu/%u bytes)\n",
+                "(%d/%u/%u/%u bytes)\n",
                 buflen - nsaved,
                 (unsigned int)nsaved,
-                recvlen,
+                (unsigned int)recvlen,

Review comment:
       I do not see any explicit way to disable `%z` warning while keeping `-Wformat` on. But I agree that since NuttX supports it's own implementation of `printf` we should relax `%z` check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org