You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/07 16:14:12 UTC
[GitHub] [spark] pan3793 commented on pull request #38901: [SPARK-41376][CORE] Correct the Netty preferDirectBufs check logic on executor start
pan3793 commented on PR #38901:
URL: https://github.com/apache/spark/pull/38901#issuecomment-1341215501
> is this the only place this check happens?
I think yes.
The following logic looks similar but not same, I think the existing code is clearly enough.
https://github.com/apache/spark/blob/1d2159f888139e65c80db2003d521b0f684df83a/common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java#L73-L79
https://github.com/apache/spark/blob/1d2159f888139e65c80db2003d521b0f684df83a/common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java#L110-L116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org