You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/19 00:44:46 UTC

[GitHub] [beam] robertwb commented on a change in pull request #13998: [BEAM-11812] Fix ULR validate runner failure caused by merging InvalidWindow

robertwb commented on a change in pull request #13998:
URL: https://github.com/apache/beam/pull/13998#discussion_r578847151



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/InvalidWindows.java
##########
@@ -87,4 +87,9 @@ public void verifyCompatibility(WindowFn<?, ?> other) throws IncompatibleWindowE
   public Instant getOutputTime(Instant inputTimestamp, W window) {
     return inputTimestamp;
   }
+
+  @Override
+  public boolean isNonMerging() {

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org