[GitHub] [ozone] umamaheswararao commented on a change in pull request #2470: HDDS-5511. ContainerStateMap should handle ecReplication config map

[GitBox <gi...@apache.org>]

umamaheswararao commented on a change in pull request #2470:
URL: https://github.com/apache/ozone/pull/2470#discussion_r681036424



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerStateMap.java
##########
@@ -85,7 +84,7 @@
 

Review comment:
       You may want to update the [documentation](https://github.com/apache/ozone/blob/e7e984c559dabe648f4ab81d0f7d901ffcc50fe6/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerStateMap.java#L65) of this class. 
   
   Currently it's talking about factor. 

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/states/ContainerStateMap.java
##########
@@ -85,7 +84,7 @@
 
   private final ContainerAttribute<LifeCycleState> lifeCycleStateMap;
   private final ContainerAttribute<String> ownerMap;
-  private final ContainerAttribute<ReplicationFactor> factorMap;
+  private final ContainerAttribute<ReplicationConfig> factorMap;

Review comment:
       you may want to rename factorMap to replicationConfigMap ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org