You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/26 17:14:53 UTC

[GitHub] [lucene] rmuir opened a new issue, #11820: smoketester needs to run 'gradlew localSettings' first

rmuir opened a new issue, #11820:
URL: https://github.com/apache/lucene/issues/11820

   ### Description
   
   smoketester runs gradle which generates a `gradle.properties` but it isn't picked up, which causes it to fail. I think if we just ran `gradlew localSettings` first, then it would actually use the `gradle.properties` that it generates?
   
   ```
   > Task :localSettings
   
   IMPORTANT. This is the first time you ran the build. I wrote some sane defaults (for this machine) to 'gradle.properties', they will be picked up on consecutive gradle invocations (not this one).
   
   Run gradlew :helpLocalSettings for more information.
   
   > Task :missing-doclet:compileJava
   > Task :missing-doclet:processResources NO-SOURCE
   > Task :missing-doclet:classes
   > Task :missing-doclet:jar
   > Task :gitStatus
   
   > Task :errorProneSkipped
   WARNING: errorprone disabled (skipped on builds not running inside CI environments, pass -Pvalidation.errorprone=true to enable)
   
   > Task :lucene:core:compileJava
   
   > Task :lucene:core:processResources
   > Task :lucene:core:classes
   > Task :lucene:core:compileMain19Java FAILED
   ```
   
   ### Version and environment details
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258369276

   Let's just add this additional exec before it executes `gradlew` for the first time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1259230934

   I have a simple PR: #11826
   
   We can introduce more advanced solutions like editing gradlew.sh/bat later. This should fix the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258367644

   Yes, on Github CI jobs we do exactly this: https://github.com/apache/lucene/blob/ac12cd9f176bf50bc80f1d7528f4c35d5ad22adf/.github/workflows/distribution.yml#L37-L44
   
   I agree this should be fixed, but that's not a showstopper. With default settings of gradle all works, it just breaks if auto-provisioning was disabled globally like on your computer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] rmuir commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
rmuir commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258366985

   To be clear, i set `JAVA19_HOME` env var, but gradle doesn't pick it up because it hasn't "pulled in" the `gradle.properties`, then it fails because it can't find java 19. I have `org.gradle.java.installations.auto-download=false` set in my `~/.gradle/gradle.properties` because i'm not allowing gradle to download JVMs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258377651

   Something like this would be fine:
   ```python
       validateCmd = './gradlew --no-daemon localSettings'
       print('    run "%s"' % validateCmd)
       java.run_java17(validateCmd, '%s/validate.log' % unpackPath)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258378657

   Anyways we should fix gradlew somehow to make sure the settings file is there and restart itsself. Maybe it should also check for updates of settings. Because once you wrote the gradle.properties file it won't be updated anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] uschindler closed issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
uschindler closed issue #11820: smoketester needs to run 'gradlew localSettings' first
URL: https://github.com/apache/lucene/issues/11820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] rmuir commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

Posted by GitBox <gi...@apache.org>.
rmuir commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1259358447

   thanks @uschindler ! it works now without any hassles.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org