You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2025/01/21 16:42:12 UTC

[PR] [SPARK-45013][TEST][3.5] Flaky Test with NPE: track allocated resources by taskId [spark]

LuciferYang opened a new pull request, #49589:
URL: https://github.com/apache/spark/pull/49589

   ### What changes were proposed in this pull request?
   This PR ensures the runningTasks to be updated before subsequent tasks causing NPE
   
   ### Why are the changes needed?
   fix flakey tests 
   
   ### Does this PR introduce _any_ user-facing change?
   no
   
   ### How was this patch tested?
   It shall fix
   ```
   - track allocated resources by taskId *** FAILED *** (36 milliseconds)
   [info]   java.lang.NullPointerException: Cannot invoke "org.apache.spark.executor.Executor$TaskRunner.taskDescription()" because the return value of "java.util.concurrent.ConcurrentHashMap.get(Object)" is null
   [info]   at org.apache.spark.executor.CoarseGrainedExecutorBackend.statusUpdate(CoarseGrainedExecutorBackend.scala:275)
   [info]   at org.apache.spark.executor.CoarseGrainedExecutorBackendSuite.$anonfun$new$22(CoarseGrainedExecutorBackendSuite.scala:351)
   [info]
   ```
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45013][CORE][TEST][3.5] Flaky Test with NPE: track allocated resources by taskId [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #49589: [SPARK-45013][CORE][TEST][3.5] Flaky Test with NPE: track allocated resources by taskId
URL: https://github.com/apache/spark/pull/49589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45013][CORE][TEST][3.5] Flaky Test with NPE: track allocated resources by taskId [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #49589:
URL: https://github.com/apache/spark/pull/49589#issuecomment-2606161803

   Thanks @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45013][CORE][TEST][3.5] Flaky Test with NPE: track allocated resources by taskId [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #49589:
URL: https://github.com/apache/spark/pull/49589#issuecomment-2605714639

   Merged to branch-3.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45013][TEST][3.5] Flaky Test with NPE: track allocated resources by taskId [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #49589:
URL: https://github.com/apache/spark/pull/49589#issuecomment-2605240660

   I hope to backport this fix to branch-3.5, as I encountered similar test failures in the daily tests of branch-3.5:
   - https://github.com/apache/spark/actions/runs/12885594112/job/35924424737
   
   ![image](https://github.com/user-attachments/assets/87eb8337-b848-4baf-ab95-a0de196772c1)
   
   
   cc @dongjoon-hyun @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45013][CORE][TEST][3.5] Flaky Test with NPE: track allocated resources by taskId [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #49589:
URL: https://github.com/apache/spark/pull/49589#issuecomment-2606354266

   BTW, please check the email, @LuciferYang .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org