You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/08 10:36:16 UTC
[GitHub] [airflow] XD-DENG commented on a change in pull request #12165: Move metrics configuration to new section - metrics
XD-DENG commented on a change in pull request #12165:
URL: https://github.com/apache/airflow/pull/12165#discussion_r519341206
##########
File path: airflow/config_templates/config.yml
##########
@@ -577,6 +577,78 @@
type: string
example: "connexion,sqlalchemy"
default: ""
+- name: metrics
+ description: |
+ StatsD (https://github.com/etsy/statsd) integration settings.
+ options:
+ - name: statsd_on
+ description: |
+ Enables sending metrics to StatsD.
+ version_added: ~
+ type: string
+ example: ~
+ default: "False"
+ - name: statsd_host
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "localhost"
+ - name: statsd_port
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "8125"
+ - name: statsd_prefix
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "airflow"
+ - name: statsd_allow_list
+ description: |
+ If you want to avoid send all the available metrics to StatsD,
Review comment:
```suggestion
If you want to avoid sending all the available metrics to StatsD,
```
##########
File path: airflow/config_templates/config.yml
##########
@@ -577,6 +577,78 @@
type: string
example: "connexion,sqlalchemy"
default: ""
+- name: metrics
+ description: |
+ StatsD (https://github.com/etsy/statsd) integration settings.
+ options:
+ - name: statsd_on
+ description: |
+ Enables sending metrics to StatsD.
+ version_added: ~
+ type: string
+ example: ~
+ default: "False"
+ - name: statsd_host
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "localhost"
+ - name: statsd_port
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "8125"
+ - name: statsd_prefix
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "airflow"
+ - name: statsd_allow_list
+ description: |
+ If you want to avoid send all the available metrics to StatsD,
+ you can configure an allow list of prefixes to send only the metrics that
Review comment:
```suggestion
you can configure an allow list of prefixes (comma separated) to send only the metrics that
```
A minor change to make it clearer to readers.
##########
File path: airflow/config_templates/config.yml
##########
@@ -577,6 +577,78 @@
type: string
example: "connexion,sqlalchemy"
default: ""
+- name: metrics
+ description: |
+ StatsD (https://github.com/etsy/statsd) integration settings.
+ options:
+ - name: statsd_on
+ description: |
+ Enables sending metrics to StatsD.
+ version_added: ~
+ type: string
+ example: ~
+ default: "False"
+ - name: statsd_host
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "localhost"
+ - name: statsd_port
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "8125"
+ - name: statsd_prefix
+ description: ~
+ version_added: ~
+ type: string
+ example: ~
+ default: "airflow"
+ - name: statsd_allow_list
+ description: |
+ If you want to avoid send all the available metrics to StatsD,
+ you can configure an allow list of prefixes to send only the metrics that
+ start with the elements of the list (e.g: scheduler,executor,dagrun)
Review comment:
```suggestion
start with the elements of the list (e.g: "scheduler,executor,dagrun")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org