[GitHub] [solr] risdenk commented on a change in pull request #688: SOLR-16040: Fix split packages in hdfs module

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #688:
URL: https://github.com/apache/solr/pull/688#discussion_r812448324



##########
File path: solr/server/scripts/cloud-scripts/snapshotscli.sh
##########
@@ -11,7 +11,7 @@ run_solr_snapshot_tool() {
     log4j_config="file:${scriptDir}/../../resources/log4j2-console.xml"
   fi
   PATH=${JAVA_HOME}/bin:${PATH} ${JVM} ${ZKCLI_JVM_FLAGS} -Dlog4j.configurationFile=${log4j_config} \
-  -classpath "${solrLibPath}" org.apache.solr.core.snapshots.SolrSnapshotsTool "$@" 2> /dev/null
+  -classpath "${solrLibPath}" org.apache.solr.hdfs.snapshots.SolrSnapshotsTool "$@" 2> /dev/null

Review comment:
       `SolrSnapshotsTool` has a bunch of HDFS specific dependencies in it. I looked at trying to separate it a little when moving HDFS to a module, but it wasn't simple. I didn't find any reference to this tool in the ref guide when I checked so I'm not sure how much it is actually used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org