[GitHub] [incubator-kvrocks] caipengbo commented on a diff in pull request #497: Add dynamically adjust the upper limit of the data that each layer configure option.

[GitBox <gi...@apache.org>]

caipengbo commented on code in PR #497:
URL: https://github.com/apache/incubator-kvrocks/pull/497#discussion_r860771700


##########
kvrocks.conf:
##########
@@ -597,6 +597,30 @@ rocksdb.enable_blob_garbage_collection yes
 # Default: 25
 rocksdb.blob_garbage_collection_age_cutoff 25
 
+
+# The purpose of following three options are to dynamically adjust the upper limit of
+# the data that each layer can store according to the size of the different 
+# layers of the LSM. Enabling this option will bring some improvements in
+# deletion efficiency and space amplification, but it will lose a certain 
+# amount of read performance.
+# If you want know more details about Levels' Target Size, you can read RocksDB wiki: 
+# https://github.com/facebook/rocksdb/wiki/Leveled-Compaction#levels-target-size
+#
+# Default: no
+rocksdb.level_compaction_dynamic_level_bytes no
+
+# The total file size of level-1 sst.
+#
+# Default: 256 M
+rocksdb.max_bytes_for_level_base 256

Review Comment:
   Yeah, I also think `bytes` is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org