[GitHub] [incubator-openwhisk] steffenrost commented on a change in pull request #4403: Add detailed error and reason information to status code

[GitBox <gi...@apache.org>]

steffenrost commented on a change in pull request #4403: Add detailed error and reason information to status code
URL: https://github.com/apache/incubator-openwhisk/pull/4403#discussion_r269988851
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/http/PoolingRestClient.scala
 ##########
 @@ -110,9 +112,17 @@ class PoolingRestClient(
       if (response.status.isSuccess) {
         Unmarshal(response.entity.withoutSizeLimit).to[T].map(Right.apply)
       } else {
-        // This is important, as it drains the entity stream.
-        // Otherwise the connection stays open and the pool dries up.
-        response.discardEntityBytes().future.map(_ => Left(response.status))
+        Unmarshal(response.entity).to[JsObject].flatMap { responseEntity =>
+          val error = responseEntity.fields.get("error").getOrElse("").toString
+          val reason = responseEntity.fields.get("reason").getOrElse("").toString
+          val statusCode = response.status
+          val statusCodeReason = statusCode.reason()
+          val customReason = s"$statusCodeReason (error: $error, reason: $reason)"
+          val customStatusCode = StatusCodes.custom(intValue = statusCode.intValue(), reason = customReason, defaultMessage = statusCode.defaultMessage())
 
 Review comment:
   > It feels... weird to overload StatusCode with more meaning than is already in the HTTP spec. Should we adjust the future to return `Either[ExpressiveErrorType, T]` rather than just statuscode?
   
   But wouldn't that be an interface change implying changes in many classes (including tests) doing REST calls using `requestJson` in `PoolingRestClient` as implementation? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services