[GitHub] [druid] jihoonson commented on issue #9351: Adding CredentialsProvider, deprecating PasswordProvider

[GitBox <gi...@apache.org>]

jihoonson commented on issue #9351:
URL: https://github.com/apache/druid/issues/9351#issuecomment-868268193


   Hi @bananaaggle, I just left some comments on the PR.
   
   > @jihoonson Hi! I want to know is there any plan to deprecate PasswordProvider. I see it marked as deprecate in code, but only few classes use DynamicConfigProvider which claimed to replace PasswordProvider. I think DynamicConfigProvider not very convenience in some places. For example, when user use config with single String like `druid.metadata.storage.connector.user=druid`, PasswordProvider is more proper than a map. So can we reserve both of them? And I try to create a EnvironmentVariableDynamicConfigProvider which works as EnvironmentVariablePasswordProvider in [#11377](https://github.com/apache/druid/pull/11377) , can you help me review it?
   
   I still think we should deprecate `PasswordProvider`. If your concern is that users now have to set a map instead of a simple string in their config, I think it's more about how we construct `DynamicConfigProvider` from the user configuration rather than using `DynamicConfigProvider`. For example, we can provide user configurations like below
   
   - `druid.metadata.storage.connector.credentials.type = mapString`
   - `druid.metadata.storage.connector.credentials.user = druid`
   - `druid.metadata.storage.connector.credentials.password = mypassword`
   
   , but construct a `MapStringDynamicConfigProvider` from these configs that has a map of `{ "user": "druid", "password": "mypassword" }`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org