[GitHub] [cloudstack] shwstppr commented on a change in pull request #4666: Fix bug in creating shared network

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #4666:
URL: https://github.com/apache/cloudstack/pull/4666#discussion_r572716532



##########
File path: ui/src/views/network/CreateSharedNetworkForm.vue
##########
@@ -628,6 +628,14 @@ export default {
         }
       }
     },
+    fetchFormPhysicalNetworkData () {
+      this.fetchPhysicalNetworkData()
+
+      // Wait until the data is fetched else it will result in NPE
+      while (this.formSelectedPhysicalNetwork === undefined ||
+            this.formSelectedPhysicalNetwork === null) {
+      }

Review comment:
       @ravening I've not been able to reproduce the original issue, were you able to identify why value remained null/undefined?
   Also, in terms of the fix here should we have a timeout as it can lead to indefinite waiting if no value is found




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org