You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2016/12/13 16:29:58 UTC

[jira] [Updated] (HBASE-17291) Remove ImmutableSegment#getKeyValueScanner

     [ https://issues.apache.org/jira/browse/HBASE-17291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ramkrishna.s.vasudevan updated HBASE-17291:
-------------------------------------------
    Attachment: HBASE-17291.patch

Patch for trunk. Removes getKVScanner() and adds a SnapshotScanner that is of type SegmentScanner. 

> Remove ImmutableSegment#getKeyValueScanner
> ------------------------------------------
>
>                 Key: HBASE-17291
>                 URL: https://issues.apache.org/jira/browse/HBASE-17291
>             Project: HBase
>          Issue Type: Improvement
>          Components: Scanners
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17291.patch
>
>
> This is based on a discussion over [~anastas]'s patch. The MemstoreSnapshot uses a KeyValueScanner which actually seems redundant considering we already have a SegmentScanner. The idea is that the snapshot scanner should be a simple iterator type of scanner but it lacks the capability to do the reference counting on that segment that is now used in snapshot. With snapshot having mulitple segments in the latest impl it is better we hold on to the segment by doing ref counting. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)