You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Subbu M Iyer (Created) (JIRA)" <ji...@apache.org> on 2012/04/04 18:25:24 UTC
[jira] [Created] (HBASE-5713) Introduce throttling during Instant
schema change process to throttle opening/closing regions.
Introduce throttling during Instant schema change process to throttle opening/closing regions.
-----------------------------------------------------------------------------------------------
Key: HBASE-5713
URL: https://issues.apache.org/jira/browse/HBASE-5713
Project: HBase
Issue Type: Bug
Components: client, master, regionserver, shell
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Priority: Minor
There is a potential for region open/close stampede during instant schema change process as the process attempts to close/open impacted regions in rapid succession. We need to introduce some kind of throttling to eliminate the race condition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5713) Introduce throttling during Instant
schema change process to throttle opening/closing regions.
Posted by "Subbu M Iyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294717#comment-13294717 ]
Subbu M Iyer commented on HBASE-5713:
-------------------------------------
Ted:
Attached a latest patch.
1. Reduced the throttle time to 100ms.
2. Addressed your comments.
All unit tests passed.
As a next step, we need to get this tested in a production grade cluster and hope Lars can help us with that.
thanks
> Introduce throttling during Instant schema change process to throttle opening/closing regions.
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-5713
> URL: https://issues.apache.org/jira/browse/HBASE-5713
> Project: HBase
> Issue Type: Bug
> Components: client, master, regionserver, shell
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Priority: Minor
> Attachments: 5713.txt, patch-v4.patch
>
>
> There is a potential for region open/close stampede during instant schema change process as the process attempts to close/open impacted regions in rapid succession. We need to introduce some kind of throttling to eliminate the race condition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5713) Introduce throttling during Instant
schema change process to throttle opening/closing regions.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5713:
------------------------------
Attachment: 5713.txt
Subbu's patch.
> Introduce throttling during Instant schema change process to throttle opening/closing regions.
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-5713
> URL: https://issues.apache.org/jira/browse/HBASE-5713
> Project: HBase
> Issue Type: Bug
> Components: client, master, regionserver, shell
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Priority: Minor
> Attachments: 5713.txt
>
>
> There is a potential for region open/close stampede during instant schema change process as the process attempts to close/open impacted regions in rapid succession. We need to introduce some kind of throttling to eliminate the race condition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5713) Introduce throttling during Instant
schema change process to throttle opening/closing regions.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261097#comment-13261097 ]
Zhihong Yu commented on HBASE-5713:
-----------------------------------
For SchemaChangeTracker.java:
{code}
+ Throwable exception
+ ) {
{code}
Please move the second line to the end of the first line.
For CompactSplitThread.java:
{code}
+import java.util.concurrent.*;
{code}
Please restore the individual imports from java.util.concurrent
{code}
while (this.server.getSchemaChangeTracker()
.isSchemaChangeInProgress(tableName)) {
try {
- Thread.sleep(100);
+ Thread.sleep(500);
{code}
Why is the sleep interval longer ?
{code}
+ <name>hbase.instant.schema.throttle.time</name>
+ <value>500</value>
+ <description>Throttle time in millis while closing/re opening impacted regions
{code}
're opening' -> 're-opening'
Since user may choose longer throttle interval, 'hbase.instant.schema.alter.timeout' should made longer.
> Introduce throttling during Instant schema change process to throttle opening/closing regions.
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-5713
> URL: https://issues.apache.org/jira/browse/HBASE-5713
> Project: HBase
> Issue Type: Bug
> Components: client, master, regionserver, shell
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Priority: Minor
> Attachments: 5713.txt
>
>
> There is a potential for region open/close stampede during instant schema change process as the process attempts to close/open impacted regions in rapid succession. We need to introduce some kind of throttling to eliminate the race condition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5713) Introduce throttling during Instant
schema change process to throttle opening/closing regions.
Posted by "Subbu M Iyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Subbu M Iyer updated HBASE-5713:
--------------------------------
Attachment: patch-v4.patch
> Introduce throttling during Instant schema change process to throttle opening/closing regions.
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-5713
> URL: https://issues.apache.org/jira/browse/HBASE-5713
> Project: HBase
> Issue Type: Bug
> Components: client, master, regionserver, shell
> Reporter: Subbu M Iyer
> Assignee: Subbu M Iyer
> Priority: Minor
> Attachments: 5713.txt, patch-v4.patch
>
>
> There is a potential for region open/close stampede during instant schema change process as the process attempts to close/open impacted regions in rapid succession. We need to introduce some kind of throttling to eliminate the race condition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira