You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Juan Larriba <jl...@gmail.com> on 2016/04/04 08:53:52 UTC

Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

Review request for mesos, Alex Clemmer and Vinod Kone.


Repository: mesos


Description
-------

Enable CMake build for Linux as an extra COMPILER option.


Diffs
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 16
> > <https://reviews.apache.org/r/45668/diff/2/?file=1328041#file1328041line16>
> >
> >     the previous version was working fine on ubuntu and centos. why the change?

It is not working for me on Ubuntu:14.04 and Ubuntu:15.10:

[root@jlarriba ~]# dirname "$0"
dirname: invalid option -- 'b'
Try 'dirname --help' for more information.

[root@jlarriba ~]# dirname -- "$0"
.


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
-----------------------------------------------------------


On Abr. 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.

> On April 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 16
> > <https://reviews.apache.org/r/45668/diff/2/?file=1328041#file1328041line16>
> >
> >     the previous version was working fine on ubuntu and centos. why the change?
> 
> Juan Larriba wrote:
>     It is not working for me on Ubuntu:14.04 and Ubuntu:15.10:
>     
>     [root@jlarriba ~]# dirname "$0"
>     dirname: invalid option -- 'b'
>     Try 'dirname --help' for more information.
>     
>     [root@jlarriba ~]# dirname -- "$0"
>     .

$0 is a bash variable that corresponds to the path of the bash script itself. When `dirname $0` is executed in the script, $0 is the path of the docker_build.sh script.

```
vagrant@vagrant-ubuntu-trusty-64:~$ dirname /foo/bar
/foo
vagrant@vagrant-ubuntu-trusty-64:~$ dirname abc
.
```


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
-----------------------------------------------------------


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 16
> > <https://reviews.apache.org/r/45668/diff/2/?file=1328041#file1328041line16>
> >
> >     the previous version was working fine on ubuntu and centos. why the change?
> 
> Juan Larriba wrote:
>     It is not working for me on Ubuntu:14.04 and Ubuntu:15.10:
>     
>     [root@jlarriba ~]# dirname "$0"
>     dirname: invalid option -- 'b'
>     Try 'dirname --help' for more information.
>     
>     [root@jlarriba ~]# dirname -- "$0"
>     .
> 
> Vinod Kone wrote:
>     $0 is a bash variable that corresponds to the path of the bash script itself. When `dirname $0` is executed in the script, $0 is the path of the docker_build.sh script.
>     
>     ```
>     vagrant@vagrant-ubuntu-trusty-64:~$ dirname /foo/bar
>     /foo
>     vagrant@vagrant-ubuntu-trusty-64:~$ dirname abc
>     .
>     ```

OK, I remove this change.


> On Abr. 7, 2016, 10:13 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 115
> > <https://reviews.apache.org/r/45668/diff/2/?file=1328041#file1328041line115>
> >
> >     How about
> >     
> >     # NOTE: Enviornment is currently ignored by CMake build because tests are not run.

That line should not be there


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
-----------------------------------------------------------


On Abr. 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.

> On April 7, 2016, 10:13 p.m., Vinod Kone wrote:
> >

Also can you create an issue on ASF JIRA (if there isn't one already) and attach it to "bugs" in this review?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
-----------------------------------------------------------


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127677
-----------------------------------------------------------




support/docker_build.sh (line 10)
<https://reviews.apache.org/r/45668/#comment191060>

    s/CONFIGURATOR/BUILDTOOL/



support/docker_build.sh (line 16)
<https://reviews.apache.org/r/45668/#comment191062>

    the previous version was working fine on ubuntu and centos. why the change?



support/docker_build.sh 
<https://reviews.apache.org/r/45668/#comment191063>

    we leave 2 blank lines between outer elements. why the change?



support/docker_build.sh (line 114)
<https://reviews.apache.org/r/45668/#comment191064>

    How about
    
    # NOTE: Enviornment is currently ignored by CMake build because tests are not run.



support/docker_build.sh (line 123)
<https://reviews.apache.org/r/45668/#comment191065>

    indent the comment with the line below.



support/docker_build.sh (line 124)
<https://reviews.apache.org/r/45668/#comment191067>

    s/mesos-cmake/build/



support/docker_build.sh (line 127)
<https://reviews.apache.org/r/45668/#comment191066>

    s/Configurator/build tool/


- Vinod Kone


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127398
-----------------------------------------------------------



Bad patch!

Reviews applied: [45668]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh 2>&1 | tee build_45668"]

Error:
+ : ubuntu:14.04
./support/docker_build.sh: line 10: CONFIGURATOR: Environment variable 'CONFIGURATOR' must be set (e.g., CONFIGURATOR=autotools)

Full log: https://builds.apache.org/job/mesos-reviewbot/12361/console

- Mesos ReviewBot


On April 6, 2016, 3:49 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.

> On April 8, 2016, 10:55 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 123
> > <https://reviews.apache.org/r/45668/diff/3/?file=1337709#file1337709line123>
> >
> >     Remove the trailing white space and put a period at the end. Also wrap at 80 chars.
> >     
> >     Also I would rephrase this as follows:
> >     
> >     # Building inside the source directory and distcheck are not currently supported 
> >     # by our CMake scripts. See MESOS-3108 for details.

Also, can you rebase?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127912
-----------------------------------------------------------


On April 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 8, 2016, 10:55 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 123
> > <https://reviews.apache.org/r/45668/diff/3/?file=1337709#file1337709line123>
> >
> >     Remove the trailing white space and put a period at the end. Also wrap at 80 chars.
> >     
> >     Also I would rephrase this as follows:
> >     
> >     # Building inside the source directory and distcheck are not currently supported 
> >     # by our CMake scripts. See MESOS-3108 for details.
> 
> Vinod Kone wrote:
>     Also, can you rebase?

Build inside the source directory is actually supported, it just seemed cleaner to me build in a different directory. But I will change it to build on the source directory.


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127912
-----------------------------------------------------------


On Abr. 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127912
-----------------------------------------------------------


Fix it, then Ship it!





support/docker_build.sh (line 122)
<https://reviews.apache.org/r/45668/#comment191286>

    Remove the trailing white space and put a period at the end. Also wrap at 80 chars.
    
    Also I would rephrase this as follows:
    
    # Building inside the source directory and distcheck are not currently supported 
    # by our CMake scripts. See MESOS-3108 for details.


- Vinod Kone


On April 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.

> On April 9, 2016, 1:34 a.m., Vinod Kone wrote:
> > support/docker_build.sh, line 125
> > <https://reviews.apache.org/r/45668/diff/5/?file=1337908#file1337908line125>
> >
> >     See the ASF CI build error on the attached ticket.
> >     
> >     I think specifying configuration options this way doesn't work with cmake.
> >     
> >     Not sure what the right way is. cc @hausdorff
> 
> Juan Larriba wrote:
>     export CONFIGURATION='-DVERBOSE="1"'

We need to make the CONFIGURATION value work with both autotools and cmake. Can you update the script to append "-D" to CONFIGURATION (you might need to append it once for each configuration value)? Also, test it locally with both autotools and cmake with the following CONFIGURATION value (--verbose --enable_libevent)


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127944
-----------------------------------------------------------


On April 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote:
> > support/docker_build.sh, line 125
> > <https://reviews.apache.org/r/45668/diff/5/?file=1337908#file1337908line125>
> >
> >     See the ASF CI build error on the attached ticket.
> >     
> >     I think specifying configuration options this way doesn't work with cmake.
> >     
> >     Not sure what the right way is. cc @hausdorff

export CONFIGURATION='-DVERBOSE="1"'


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127944
-----------------------------------------------------------


On Abr. 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote:
> > support/docker_build.sh, line 125
> > <https://reviews.apache.org/r/45668/diff/5/?file=1337908#file1337908line125>
> >
> >     See the ASF CI build error on the attached ticket.
> >     
> >     I think specifying configuration options this way doesn't work with cmake.
> >     
> >     Not sure what the right way is. cc @hausdorff
> 
> Juan Larriba wrote:
>     export CONFIGURATION='-DVERBOSE="1"'
> 
> Vinod Kone wrote:
>     We need to make the CONFIGURATION value work with both autotools and cmake. Can you update the script to append "-D" to CONFIGURATION (you might need to append it once for each configuration value)? Also, test it locally with both autotools and cmake with the following CONFIGURATION value (--verbose --enable_libevent)

The configuration options for autotools and cmake have a completely different syntax, so I do not see the point in translating the autotools configuration options to cmake options.

I can do the translation, but don't you think it would be more elegant to pass the adequate configuration options for the used buildtools?


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127944
-----------------------------------------------------------


On Abr. 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127944
-----------------------------------------------------------




support/docker_build.sh (line 124)
<https://reviews.apache.org/r/45668/#comment191335>

    See the ASF CI build error on the attached ticket.
    
    I think specifying configuration options this way doesn't work with cmake.
    
    Not sure what the right way is. cc @hausdorff


- Vinod Kone


On April 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127955
-----------------------------------------------------------



Bad patch!

Reviews applied: [45668]

Failed command: ./support/apply-review.sh -n -r 45668

Error:
2016-04-09 05:11:22 URL:https://reviews.apache.org/r/45668/diff/raw/ [2693/2693] -> "45668.patch" [1]
error: patch failed: support/docker_build.sh:59
error: support/docker_build.sh: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12420/console

- Mesos ReviewBot


On April 8, 2016, 11:26 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 11:26 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review129386
-----------------------------------------------------------



Bad patch!

Reviews applied: [45668]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh 2>&1 | tee build_45668"]

Error:
+ : ubuntu:14.04
./support/docker_build.sh: line 10: BUILDTOOL: Environment variable 'BUILDTOOL' must be set (e.g., BUILDTOOL=autotools)

Full log: https://builds.apache.org/job/mesos-reviewbot/12594/console

- Mesos ReviewBot


On April 18, 2016, 1:58 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote:
> > support/docker_build.sh, lines 127-140
> > <https://reviews.apache.org/r/45668/diff/5-6/?file=1337908#file1337908line127>
> >
> >     Hmm. I was hoping for something more generic than hard coding these 3 configurations. But if it's not easy to auto translate and the configuration options for CMAKE are truly different from Autotools, I'm ok with not doing this change here and instead have 2 different Jenkins jobs (one for Mesos w/ Auto-tools and one for Mesos w/ CMake); was just hoping we could get away with having just one Jenkins job (parameterized).
> 
> Juan Larriba wrote:
>     I will try to submit a more generic proposal to convert from autotools to cmake parameters so the same Jenkins job can be used for building, I have had a lot of work this past week and couldn't do anything. However, I still do not understand why the BUILDTOOL or the COMPILER parameters can change between job executions and the CONFIGURATION parameter cannot change at the same time.
> 
> Vinod Kone wrote:
>     The ASF CI job is setup as a paremeterized job (https://builds.apache.org/view/M-R/view/Mesos/job/Mesos/). The parameters are the environment varialbes (BUILDTOOL, COMPILER, CONFIGURATION etc). So all the combinations of the environmental varialbles should work.
>     
>     For example if we have the following envs,
>     
>     BUILDTOOL = "'autotools' 'cmake'"
>     COMPILER = "'gcc' 'clang'"
>     CONFIGURATION = "'--verbose' '--enable_libevent'"
>     
>     Then all the combinations of these should work.
>     
>     autotools x gcc x --verbose
>     autotools x gcc x --enable_libevent
>     autotools x clang x --verbose
>     autotools x clang x --enable_libevent
>     cmake x gcc x --verbose
>     cmake x gcc x --enable_libevent
>     cmake x clang x --verbose
>     cmake x clang x --enable_libevent
>     
>     Hope this makes sense?

Thank you very much Vinod, now it makes sense

The fact is that I do not have permissions to see the internals of the job (the link you pasted), so I couldn't figure out how the build was being executed. I will submit the modifications needed to convert from autotools CONFIGURATION to cmake CONFIGURATION.


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review129387
-----------------------------------------------------------


On Abr. 18, 2016, 1:58 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 18, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

Posted by Vinod Kone <vi...@gmail.com>.

> On April 18, 2016, 6:18 p.m., Vinod Kone wrote:
> > support/docker_build.sh, lines 127-140
> > <https://reviews.apache.org/r/45668/diff/5-6/?file=1337908#file1337908line127>
> >
> >     Hmm. I was hoping for something more generic than hard coding these 3 configurations. But if it's not easy to auto translate and the configuration options for CMAKE are truly different from Autotools, I'm ok with not doing this change here and instead have 2 different Jenkins jobs (one for Mesos w/ Auto-tools and one for Mesos w/ CMake); was just hoping we could get away with having just one Jenkins job (parameterized).
> 
> Juan Larriba wrote:
>     I will try to submit a more generic proposal to convert from autotools to cmake parameters so the same Jenkins job can be used for building, I have had a lot of work this past week and couldn't do anything. However, I still do not understand why the BUILDTOOL or the COMPILER parameters can change between job executions and the CONFIGURATION parameter cannot change at the same time.

The ASF CI job is setup as a paremeterized job (https://builds.apache.org/view/M-R/view/Mesos/job/Mesos/). The parameters are the environment varialbes (BUILDTOOL, COMPILER, CONFIGURATION etc). So all the combinations of the environmental varialbles should work.

For example if we have the following envs,

BUILDTOOL = "'autotools' 'cmake'"
COMPILER = "'gcc' 'clang'"
CONFIGURATION = "'--verbose' '--enable_libevent'"

Then all the combinations of these should work.

autotools x gcc x --verbose
autotools x gcc x --enable_libevent
autotools x clang x --verbose
autotools x clang x --enable_libevent
cmake x gcc x --verbose
cmake x gcc x --enable_libevent
cmake x clang x --verbose
cmake x clang x --enable_libevent

Hope this makes sense?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review129387
-----------------------------------------------------------


On April 18, 2016, 1:58 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 125
> > <https://reviews.apache.org/r/45668/diff/5-6/?file=1337908#file1337908line125>
> >
> >     What is this for?

It tells CMake the generator that it needs to use to generate build files.


> On Abr. 18, 2016, 6:18 p.m., Vinod Kone wrote:
> > support/docker_build.sh, lines 127-140
> > <https://reviews.apache.org/r/45668/diff/5-6/?file=1337908#file1337908line127>
> >
> >     Hmm. I was hoping for something more generic than hard coding these 3 configurations. But if it's not easy to auto translate and the configuration options for CMAKE are truly different from Autotools, I'm ok with not doing this change here and instead have 2 different Jenkins jobs (one for Mesos w/ Auto-tools and one for Mesos w/ CMake); was just hoping we could get away with having just one Jenkins job (parameterized).

I will try to submit a more generic proposal to convert from autotools to cmake parameters so the same Jenkins job can be used for building, I have had a lot of work this past week and couldn't do anything. However, I still do not understand why the BUILDTOOL or the COMPILER parameters can change between job executions and the CONFIGURATION parameter cannot change at the same time.


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review129387
-----------------------------------------------------------


On Abr. 18, 2016, 1:58 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 18, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review129387
-----------------------------------------------------------




support/docker_build.sh (line 125)
<https://reviews.apache.org/r/45668/#comment192821>

    What is this for?



support/docker_build.sh (lines 127 - 140)
<https://reviews.apache.org/r/45668/#comment192823>

    Hmm. I was hoping for something more generic than hard coding these 3 configurations. But if it's not easy to auto translate and the configuration options for CMAKE are truly different from Autotools, I'm ok with not doing this change here and instead have 2 different Jenkins jobs (one for Mesos w/ Auto-tools and one for Mesos w/ CMake); was just hoping we could get away with having just one Jenkins job (parameterized).


- Vinod Kone


On April 18, 2016, 1:58 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 1:58 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 18, 2016, 1:58 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
-------

Addded compatibility for CMake build with autotools CONFIGURATION options


Summary (updated)
-----------------

Enable CMake build for Linux as a BUILDTOOL option.


Bugs: MESOS-5101
    https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description
-------

Enable CMake build for Linux as a BUILDTOOL option.


Diffs (updated)
-----

  support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 18, 2016, 11:57 a.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Bugs: MESOS-5101
    https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
-------

Enable CMake build for Linux as a BUILDTOOL option.


Diffs
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 8, 2016, 11:26 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
-------

Remove trailing space


Bugs: MESOS-5101
    https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
-------

Enable CMake build for Linux as new CONFIGURATOR option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Diffs (updated)
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 8, 2016, 11:24 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
-------

Rephrased and rebased


Bugs: MESOS-5101
    https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
-------

Enable CMake build for Linux as new CONFIGURATOR option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Diffs (updated)
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review127908
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 8, 2016, 10:41 p.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 10:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
> 
> 
> Bugs: MESOS-5101
>     https://issues.apache.org/jira/browse/MESOS-5101
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enable CMake build for Linux as new CONFIGURATOR option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Enable CMake build for Linux as a BUILDTOOL option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 8, 2016, 10:41 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
-------

Implemented changes required by Vinod's review


Bugs: MESOS-5101
    https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description (updated)
-------

Enable CMake build for Linux as new CONFIGURATOR option.


Enable CMake build for Linux as a BUILDTOOL option.


Enable CMake build for Linux as a BUILDTOOL option.


Diffs (updated)
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 8, 2016, 10:31 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
-------

Added Jira issue in "bugs"


Bugs: MESOS-5101
    https://issues.apache.org/jira/browse/MESOS-5101


Repository: mesos


Description
-------

Enable CMake build for Linux as new CONFIGURATOR option.


Diffs
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 6, 2016, 3:49 p.m.)


Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.


Changes
-------

Added CMake as a new CONFIGURATOR option (which can be autotools or cmake). CMake uses both gcc and clang to build.


Summary (updated)
-----------------

Enable CMake build for Linux as a CONFIGURATOR option.


Repository: mesos


Description (updated)
-------

Enable CMake build for Linux as new CONFIGURATOR option.


Diffs (updated)
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing (updated)
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.


Thanks,

Juan Larriba

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review126804
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45668]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 6:54 a.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [MESOS-5101] Enable CMake build for Linux as an extra COMPILER option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

Posted by Juan Larriba <jl...@gmail.com>.

> On Abr. 4, 2016, 12:32 p.m., Joerg Schad wrote:
> > support/docker_build.sh, line 19
> > <https://reviews.apache.org/r/45668/diff/1/?file=1323922#file1323922line19>
> >
> >     What is the reason for this change? Was it a bug before? (Feel free to drop if there is a good reason, it just seems unclear at this point why you changed it).

Yes, it is a bug, at least on Ubuntu and CentOS:

[root@jlarriba ~]# dirname "$0"
dirname: invalid option -- 'b'
Try 'dirname --help' for more information.

[root@jlarriba ~]# dirname -- "$0"
.


> On Abr. 4, 2016, 12:32 p.m., Joerg Schad wrote:
> > support/docker_build.sh, line 21
> > <https://reviews.apache.org/r/45668/diff/1/?file=1323922#file1323922line21>
> >
> >     Do we need these echo 1 etc for something? Or is it just for debugging?

It is indeed for debugging; It should not be there.


> On Abr. 4, 2016, 12:32 p.m., Joerg Schad wrote:
> > support/docker_build.sh, line 90
> > <https://reviews.apache.org/r/45668/diff/1/?file=1323922#file1323922line90>
> >
> >     again it feels weird to see cmake on the same level as gcc vs clang.
> >     Shouldn't these decisions be orthogonal (i.e., using Cmake and gcc, cmake and clang, autotools and gcc, ...)

I don't know about this. Currently CMake always uses gcc to compile, I have not tried to use clang with CMake yet. However, making it orthogonal makes sense, I will try to build using cmake with clang and make it orthogonal.


> On Abr. 4, 2016, 12:32 p.m., Joerg Schad wrote:
> > support/docker_build.sh, line 91
> > <https://reviews.apache.org/r/45668/diff/1/?file=1323922#file1323922line91>
> >
> >     Why is this needed here?

Just to notice the build that cmake is being used, just in case. However, if we make the build orthogonal, this will dissapear.


> On Abr. 4, 2016, 12:32 p.m., Joerg Schad wrote:
> > support/docker_build.sh, line 1
> > <https://reviews.apache.org/r/45668/diff/1/?file=1323922#file1323922line1>
> >
> >     When testing did you test both cmake and the non-cmake way on both systems? If so could you make this explicit in testing done? 
> >     THX!

I did not test the non-cmake way, but I will and modify the testing done field.


- Juan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review126819
-----------------------------------------------------------


On Abr. 4, 2016, 6:54 a.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated Abr. 4, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [MESOS-5101] Enable CMake build for Linux as an extra COMPILER option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review126819
-----------------------------------------------------------




support/docker_build.sh (line 1)
<https://reviews.apache.org/r/45668/#comment189906>

    When testing did you test both cmake and the non-cmake way on both systems? If so could you make this explicit in testing done? 
    THX!



support/docker_build.sh (line 19)
<https://reviews.apache.org/r/45668/#comment189905>

    What is the reason for this change? Was it a bug before? (Feel free to drop if there is a good reason, it just seems unclear at this point why you changed it).



support/docker_build.sh (line 21)
<https://reviews.apache.org/r/45668/#comment189901>

    Do we need these echo 1 etc for something? Or is it just for debugging?



support/docker_build.sh (line 90)
<https://reviews.apache.org/r/45668/#comment189904>

    again it feels weird to see cmake on the same level as gcc vs clang.
    Shouldn't these decisions be orthogonal (i.e., using Cmake and gcc, cmake and clang, autotools and gcc, ...)



support/docker_build.sh (line 91)
<https://reviews.apache.org/r/45668/#comment189908>

    Why is this needed here?


- Joerg Schad


On April 4, 2016, 6:54 a.m., Juan Larriba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [MESOS-5101] Enable CMake build for Linux as an extra COMPILER option.
> 
> 
> Diffs
> -----
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
> 
> Diff: https://reviews.apache.org/r/45668/diff/
> 
> 
> Testing
> -------
> 
> Built using docker_build.sh on both centos:7 and ubuntu:14.04
> 
> 
> Thanks,
> 
> Juan Larriba
> 
>

Re: Review Request 45668: Enable CMake build for Linux as an extra COMPILER option.

Posted by Juan Larriba <jl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/
-----------------------------------------------------------

(Updated Abr. 4, 2016, 6:54 a.m.)


Review request for mesos, Alex Clemmer and Vinod Kone.


Repository: mesos


Description (updated)
-------

[MESOS-5101] Enable CMake build for Linux as an extra COMPILER option.


Diffs
-----

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 

Diff: https://reviews.apache.org/r/45668/diff/


Testing
-------

Built using docker_build.sh on both centos:7 and ubuntu:14.04


Thanks,

Juan Larriba