You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Julian Hyde (Jira)" <ji...@apache.org> on 2019/09/30 18:30:00 UTC

[jira] [Comment Edited] (CALCITE-3381) BigQuerySqlDialect should cast Calcite SQL types to BigQuery types

    [ https://issues.apache.org/jira/browse/CALCITE-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941231#comment-16941231 ] 

Julian Hyde edited comment on CALCITE-3381 at 9/30/19 6:29 PM:
---------------------------------------------------------------

Thanks, that's an improvement, but take a look at the message for CALCITE-3282, which is a very similar change.

By which I mean the commit message for [f3758a6f|https://github.com/apache/calcite/commit/f3758a6fa301cbd910ceabeca9075a3772ee4e8b].


was (Author: julianhyde):
Thanks, that's an improvement, but take a look at the message for CALCITE-3282, which is a very similar change.

> BigQuerySqlDialect should cast Calcite SQL types to BigQuery types
> ------------------------------------------------------------------
>
>                 Key: CALCITE-3381
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3381
>             Project: Calcite
>          Issue Type: New Feature
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Kirill Kozlov
>            Priority: Minor
>
> When using `SqlImplementor.SimpleContext#toSql` with BigQuerySqlDialect on Rel nodes containing `CAST` need to convert Calcite SqlTypeName to BigQuery supported types ([https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types]).
> I believe this can be accomplished by Overriding BigQuerySqlDialect#getCastSpec method.
> Example: VARCHAR should become a STRING, BOOLEAN - BOOL, and so on.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)