You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/04/13 12:36:22 UTC
[PR] Use containsOnce for metadata e2e expected files [skywalking]
wu-sheng opened a new pull request, #13815:
URL: https://github.com/apache/skywalking/pull/13815
### Use containsOnce for stricter metadata verification in e2e tests
Migrate outer-level `contains` to `containsOnce` in 101 expected files:
- **57 service.yml** — exact service names and IDs
- **15 instance.yml** — known service instances
- **5 endpoint.yml** — exact endpoint names
- **24 topology files** — aggregated nodes and calls (no duplicates)
`containsOnce` uses backtracking for optimal 1:1 assignment between expected and actual entries, ensuring each actual item matches exactly one expected entry. This is more precise than greedy `contains` for metadata where we know exactly which entries should exist.
Inner nested `contains` (`.layers`, `.tags`, etc.) are left unchanged.
**Verified locally** with the locally-built infra-e2e binary against mock data for service, instance, and topology patterns.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use containsOnce for metadata e2e expected files [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #13815:
URL: https://github.com/apache/skywalking/pull/13815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org