[jira] [Comment Edited] (LIBCLOUD-429) Unicode filenames on Python 2 cause urlquote to fail

["Michael Farrell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812590#comment-13812590 ] 

Michael Farrell edited comment on LIBCLOUD-429 at 11/4/13 3:24 AM:
-------------------------------------------------------------------

I've extended the unit tests now to include some different tests.  These still appear to check out.  I've had to wrap the output in {{b()}} as {{urlquote}} on py3.3 returns a {{unicode}} (not {{bytestring}}).  I think it was related to me previously using a pre-3.3 Mercurial version of Python when I was writing some other patch, and now I'm on 3.3.2.

https://github.com/Caramel/libcloud/compare/trunk...libcloud-429


was (Author: micolous):
I've extended the unit tests now to include some different tests.  These still appear to check out.  I've had to wrap the output in {{b()}} as {{urlquote}} on py3.3 returns a unicode.  I think it was related to me previously using a pre-3.3 Mercurial version of Python when I was writing some other patch, and now I'm on 3.3.2.

https://github.com/Caramel/libcloud/compare/trunk...libcloud-429

> Unicode filenames on Python 2 cause urlquote to fail
> ----------------------------------------------------
>
>                 Key: LIBCLOUD-429
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-429
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Storage
>    Affects Versions: 0.13.2
>         Environment: Python 2.6, 2.7
>            Reporter: Michael Farrell
>
> Using filenames (or anything that urlquote is passed) on Python 2 cause an exception:
> {code}
>   File "/usr/lib/python2.7/urllib.py", line 1268, in quote
>     return ''.join(map(quoter, s))
> KeyError: u'\xe9'
> {code}
> There is a compatibility module {{libcloud.utils.py3}} which is supposed to handle compatibility issues between the two Python versions.
> I've written a test case for this error and a patch.  It appears to function correctly on Python 2.6, 2.7 and 3.3.



--
This message was sent by Atlassian JIRA
(v6.1#6144)