You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/23 06:43:50 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #262: feat: ApisixRoute v2alpha1
tokers opened a new pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
#248
___
### New feature or improvement
- Describe the details and related test reports.
This PR implemented the ApisixRoute.apisix.apache.org/v2/alpha1 resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#issuecomment-783950278
@gxthrj Please take a look when you have time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r582535841
##########
File path: pkg/ingress/controller/controller.go
##########
@@ -338,17 +340,6 @@ type Api6Controller struct {
Stop <-chan struct{}
}
-func (api6 *Api6Controller) ApisixRoute(controller *Controller) {
Review comment:
We discussed earlier that we should keep the v1 version for a while, declare in the document "deprecated", and delete the logic of v1 in version 1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#issuecomment-785590961
Conflicting files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#issuecomment-787784703
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=h1) Report
> Merging [#262](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=desc) (de03db9) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.58%`.
> The diff coverage is `9.87%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 53.85% 52.26% -1.59%
==========================================
Files 33 32 -1
Lines 2245 2319 +74
==========================================
+ Hits 1209 1212 +3
- Misses 879 950 +71
Partials 157 157
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <ø> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <100.00%> (+0.35%)` | :arrow_up: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <100.00%> (+0.48%)` | :arrow_up: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `4.00% <0.00%> (+2.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=footer). Last update [0c8f306...de03db9](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r582551116
##########
File path: pkg/ingress/controller/controller.go
##########
@@ -338,17 +340,6 @@ type Api6Controller struct {
Stop <-chan struct{}
}
-func (api6 *Api6Controller) ApisixRoute(controller *Controller) {
Review comment:
Sorry I forgot to set this PR to draft, the v1 ApisixRoute will be kept of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r586137386
##########
File path: test/e2e/ingress/resourcepushing.go
##########
@@ -64,19 +76,21 @@ spec:
ginkgo.It("create and then remove", func() {
backendSvc, backendSvcPort := s.DefaultHTTPBackend()
apisixRoute := fmt.Sprintf(`
-apiVersion: apisix.apache.org/v1
+apiVersion: apisix.apache.org/v2alpha1
kind: ApisixRoute
metadata:
name: httpbin-route
spec:
- rules:
- - host: httpbin.com
- http:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.com
paths:
- - backend:
- serviceName: %s
- servicePort: %d
- path: /ip
+ - /ip
+ backend:
+ serviceName: %s
+ servicePort: %d
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#issuecomment-787784703
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=h1) Report
> Merging [#262](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=desc) (557a88b) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.67%`.
> The diff coverage is `9.87%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 53.85% 52.17% -1.68%
==========================================
Files 33 32 -1
Lines 2245 2319 +74
==========================================
+ Hits 1209 1210 +1
- Misses 879 952 +73
Partials 157 157
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <ø> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <100.00%> (+0.35%)` | :arrow_up: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <100.00%> (+0.48%)` | :arrow_up: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=footer). Last update [0c8f306...3d90130](https://codecov.io/gh/apache/apisix-ingress-controller/pull/262?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #262:
URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r586049600
##########
File path: test/e2e/ingress/resourcepushing.go
##########
@@ -64,19 +76,21 @@ spec:
ginkgo.It("create and then remove", func() {
backendSvc, backendSvcPort := s.DefaultHTTPBackend()
apisixRoute := fmt.Sprintf(`
-apiVersion: apisix.apache.org/v1
+apiVersion: apisix.apache.org/v2alpha1
kind: ApisixRoute
metadata:
name: httpbin-route
spec:
- rules:
- - host: httpbin.com
- http:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.com
paths:
- - backend:
- serviceName: %s
- servicePort: %d
- path: /ip
+ - /ip
+ backend:
+ serviceName: %s
+ servicePort: %d
Review comment:
Need more test case with v2alpha1. We may add more in future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org