Re: cvs commit: httpd-2.0/modules/arch/netware mod_nw_ssl.c

[Joe Orton <jo...@redhat.com>]

On Sun, Mar 07, 2004 at 03:08:21AM -0000, bnicholes@apache.org wrote:
> bnicholes    2004/03/06 19:08:21
> 
>   Modified:    modules/arch/netware mod_nw_ssl.c
>   Log:
>   Add the ssl_is_https() and ssl_var_lookup() optional functions to the  mod_nw_ssl module for Netware

If you intend mod_nw_ssl to be implement hooks which are compatible with
mod_ssl, it should simply #include "mod_ssl.h" rather than
copy'n'pasting the hook declarations.  Copy'n'pasting all of
ssl_var_lookup is still very ugly :(

...
>   +/* The ssl_var_lookup() optional function retrieves SSL environment
>   + * variables. */
>   +APR_DECLARE_OPTIONAL_FN(char *, ssl_var_lookup,
>   +                        (apr_pool_t *, server_rec *,
>   +                         conn_rec *, request_rec *,
>   +                         char *));
>   +
>   +/* An optional function which returns non-zero if the given connection
>   + * is using SSL/TLS. */
>   +APR_DECLARE_OPTIONAL_FN(int, ssl_is_https, (conn_rec *));
>   +
>   +/* The ssl_proxy_enable() and ssl_engine_disable() optional functions
>   + * are used by mod_proxy to enable use of SSL for outgoing
>   + * connections. */
>    APR_DECLARE_OPTIONAL_FN(int, ssl_proxy_enable, (conn_rec *));
>    APR_DECLARE_OPTIONAL_FN(int, ssl_engine_disable, (conn_rec *));