[jira] [Commented] (GUACAMOLE-818) Missing some files in the sftp file system

["Mike Jumper (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044031#comment-17044031 ] 

Mike Jumper commented on GUACAMOLE-818:
---------------------------------------

Editing the comment such that the source referenced is readable, it doesn't look like there are any specific changes proposed. The code listed is identical to what is currently present, with the exception of an additional call to {{guac_common_write_property()}} outside the {{while}} loop.

Assuming that additional call is intentional and is what [~kwanghee83.lee] refers to, I'm not sure there are actual changes corresponding to this. It can't compile as it stands (the {{mimetype}} variable not declared outside the scope of the {{while}} loop), and I get the feeling it was just an untested suggestion as to where to look.

[~kwanghee83.lee], feel free to open a pull request if I'm wrong here.

> Missing some files in the sftp file system
> ------------------------------------------
>
>                 Key: GUACAMOLE-818
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-818
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole
>    Affects Versions: 1.0.0
>            Reporter: kwangheelee
>            Assignee: Mike Jumper
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: blob-20190621.json, filesystem1.png, filesystem2.png, location-of-20190419-within-json.png, missing1.png, missing2.png
>
>
> I am currently developing using Guacamole version 1.0.0. There are some bugs in uploading/downloading files through the sftp file system.
> I checked the source and found that when importing the sftp file structure, if the number of files and directories is large, it is obtained by dividing buffer. It does not matter when the number of files is small, but when the number of files is large, it is confirmed that some files are missing.
> For example, when loading a file system with three buffers, two files are missing. 
> =============================================================
> Client : 3.get,1.0,31./home/guacd/guacamole/recording;
>  Server : 4.body,1.0,1.0,53.application/vnd.glyptodon.guacamole.stream-index+json,31./home/guacd/guacamole/recording;
>  Client : 3.ack,1.0,5.Ready,1.0;
>  Server : 4.blob,1.0,5416.SOME DATA;
>  Client : 3.ack,1.0,8.Received,1.0;
>  Server : 4.blob,1.0,3168.SOME DATA;3.end,1.0;
>  client : 3.ack,1.0,8.Received,1.0;
> =============================================================
> I do not know if it is a guacamole issue or a libssh2 issue, and I would like to make a correction.
> Attachment can not be transferred because of security problem in company system.
> (Please write your email address in Comments and I will send you an attachment.)
> Thanks.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)