You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/10/29 18:23:22 UTC
[GitHub] [nifi] mattyb149 opened a new pull request #5496: NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
mattyb149 opened a new pull request #5496:
URL: https://github.com/apache/nifi/pull/5496
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Changes wording in Registry UI for clarity and consistency
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #5496: NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #5496:
URL: https://github.com/apache/nifi/pull/5496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5496: NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #5496:
URL: https://github.com/apache/nifi/pull/5496#issuecomment-1069421002
After fixing the typo, getting the +1 from Andrew, and fixing the merge conflict, this one's good to go. Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] andrewmlim commented on pull request #5496: NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
Posted by GitBox <gi...@apache.org>.
andrewmlim commented on pull request #5496:
URL: https://github.com/apache/nifi/pull/5496#issuecomment-1069292669
@mattyb149 Any reason to not push this over the finish line? LGTM after Pierre's suggestions were implemented. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #5496: NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #5496:
URL: https://github.com/apache/nifi/pull/5496#issuecomment-1068589496
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on a change in pull request #5496: NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on a change in pull request #5496:
URL: https://github.com/apache/nifi/pull/5496#discussion_r748867154
##########
File path: nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/services/nf-registry.service.spec.js
##########
@@ -77,10 +77,10 @@ describe('NfRegistry Service isolated unit tests', function () {
const label = nfRegistryService.getSortByLabel();
//assertions
- expect(label).toBe('Newest (update)');
+ expect(label).toBe('LastUpdated (newest)');
Review comment:
```suggestion
expect(label).toBe('Last Updated (newest)');
```
##########
File path: nifi-registry/nifi-registry-core/nifi-registry-web-ui/src/main/webapp/services/nf-registry.service.spec.js
##########
@@ -68,7 +68,7 @@ describe('NfRegistry Service isolated unit tests', function () {
expect(label).toBe('Name (a - z)');
});
- it('should get the `Newest (update)` sort by label', function () {
+ it('should get the `LastUpdated (newest)` sort by label', function () {
Review comment:
```suggestion
it('should get the `Last Updated (newest)` sort by label', function () {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] andrewmlim commented on pull request #5496: NIFI-9316: Registry Sort by label should be 'Last Updated (newest)' not 'Newest (update)'
Posted by GitBox <gi...@apache.org>.
andrewmlim commented on pull request #5496:
URL: https://github.com/apache/nifi/pull/5496#issuecomment-1069319756
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org