You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/23 14:39:29 UTC

Review Request 29369: CLOUDSTACK-8117: Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29369/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-8117
    https://issues.apache.org/jira/browse/CLOUDSTACK-8117


Repository: cloudstack-git


Description
-------

Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering.

Large component of memory is consumed by the UI component, hence the memory for VM is listed lesser than that is specified in the service offering.

Increase the range from 20 to 200 for hyperv because of the difference in template used.

TODO: Find a way to get memory allolcated to VM on hyperv using powershell commands and use it to equate it to the memory specified in service offering.

Also fixed pep8 issues.


Diffs
-----

  test/integration/smoke/test_service_offerings.py e390f75 

Diff: https://reviews.apache.org/r/29369/diff/


Testing
-------

Yes.


Thanks,

Gaurav Aradhye


Re: Review Request 29369: CLOUDSTACK-8117: Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29369/#review66020
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Dec. 23, 2014, 1:39 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29369/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 1:39 p.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8117
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8117
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Increased the allowed margin (+/-) for memory of VM on hyperv used to equate with the memory specified in service offering.
> 
> Large component of memory is consumed by the UI component, hence the memory for VM is listed lesser than that is specified in the service offering.
> 
> Increase the range from 20 to 200 for hyperv because of the difference in template used.
> 
> TODO: Find a way to get memory allolcated to VM on hyperv using powershell commands and use it to equate it to the memory specified in service offering.
> 
> Also fixed pep8 issues.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_service_offerings.py e390f75 
> 
> Diff: https://reviews.apache.org/r/29369/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>