[jira] [Comment Edited] (ACCUMULO-1499) Move sanity checks from MiniAccumuloCluster constructor into MiniAccumuloConfig.initialize method.

["Corey J. Nolet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13687925#comment-13687925 ] 

Corey J. Nolet edited comment on ACCUMULO-1499 at 6/19/13 12:37 PM:
--------------------------------------------------------------------

Thrift version 0.9.0. I'm on a mac, but that shouldn't make any difference. To note, I have noticed that my mac has generated random thrift files while working on patches a couple of months ago. By random, I mean files that weren't affected by any changes that I had made. I just won't check them in anymore unless they are a result of changes i've made.

                
      was (Author: sonixbp):
    Thrift version 0.9.0. I'm on a mac, but that shouldn't make any difference.


On Wed, Jun 19, 2013 at 8:24 AM, Christopher Tubbs (JIRA)


                  
> Move sanity checks from MiniAccumuloCluster constructor into MiniAccumuloConfig.initialize method.
> --------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-1499
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-1499
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: David Medinets
>            Priority: Trivial
>             Fix For: 1.6.0
>
>         Attachments: ACCUMULO-1499.patch
>
>
> The code below seems like it should be in the config class:
>     if (config.getDir().exists() && !config.getDir().isDirectory())
>       throw new IllegalArgumentException("Must pass in directory, " + config.getDir() + " is a file");
>     if (config.getDir().exists() && config.getDir().list().length != 0)
>       throw new IllegalArgumentException("Directory " + config.getDir() + " is not empty");
>     this.config = config.initialize();
> Any objections to this change?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira