[GitHub] [nifi] adenes commented on pull request #5414: NIFI-9248 Use hive-exec:core instead of the "regular" hive-exec dependency

[GitBox <gi...@apache.org>]

adenes commented on pull request #5414:
URL: https://github.com/apache/nifi/pull/5414#issuecomment-929212599


   Thanks for the comment, @exceptionfactory 
   
   > For reference, what factors determined which explicit dependencies to include after excluding `hive-exec` from `hive-streaming`? The Maven configuration for `hive-exec` appears to include a handful of additional dependencies, but are all of those available through currently declared dependencies? It would be helpful to have some process to track this down in the event of future version updates to `hive-exec`.
   
   I ran a `mvn dependency:tree` on the `nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors` module and checked which dependencies are missing from the list [1] and added the missing ones as direct dependencies.
   
   I had an ugly oneliner:
   `(for a in `cat ~/tmp/hive-shadedlibs`; do ver=$(cat deptree | grep $a | grep -E ":compile|:runtime" | head -1 | grep -Eo ":\d+(\.\d+)*"); echo $a$ver; done) >result`
   where 
   - `~/tmp/hive-shadedlibs` was manually created from the below linked hive `pom.xml` snippet in the format of `groupId:artifactId` - https://gist.github.com/adenes/7711eb7bd7873002ae46022c84d7cab1
   - `deptree` is the output of `mvn dependency:tree -pl nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors`
   - the output of this (`result`) should contain all the libraries from the `hive-shadedlibs` with version number - https://gist.github.com/adenes/f5a734be1fb78af9fbf3a49edf05e1fe
   
   
   [1] https://github.com/apache/hive/blob/rel/release-3.1.2/ql/pom.xml#L925-L961
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org