You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/09/27 21:56:57 UTC
[GitHub] [solr] tflobbe opened a new pull request, #1046: SOLR-16435: Add Request timeout to Http2SolrClient
tflobbe opened a new pull request, #1046:
URL: https://github.com/apache/solr/pull/1046
Adding the option to Http2SolrClient. For the Cloud client, users need to use `withInternalClientBuilder` and provide a builder, similar to how they use for setting the other timeouts, authentication, etc.
Will update CHANGES once this gets reviewed, but my plan is to merge into 9.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] anshumg commented on a diff in pull request #1046: SOLR-16435: Add Request timeout to Http2SolrClient
Posted by GitBox <gi...@apache.org>.
anshumg commented on code in PR #1046:
URL: https://github.com/apache/solr/pull/1046#discussion_r983956769
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -519,7 +525,11 @@ private Request makeRequest(SolrRequest<?> solrRequest, String collection)
private void decorateRequest(Request req, SolrRequest<?> solrRequest) {
req.header(HttpHeader.ACCEPT_ENCODING, null);
- req.timeout(idleTimeout, TimeUnit.MILLISECONDS);
+ if (requestTimeout > 0) {
Review Comment:
If someone accidentally sets this to 0, we'd just be ignoring it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on pull request #1046: SOLR-16435: Add Request timeout to Http2SolrClient
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #1046:
URL: https://github.com/apache/solr/pull/1046#issuecomment-1260151286
:warning: **313 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GE0F7YN8NCZ3XQ9037HX3JN2?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20solr) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe commented on a diff in pull request #1046: SOLR-16435: Add Request timeout to Http2SolrClient
Posted by GitBox <gi...@apache.org>.
tflobbe commented on code in PR #1046:
URL: https://github.com/apache/solr/pull/1046#discussion_r984037079
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -519,7 +525,11 @@ private Request makeRequest(SolrRequest<?> solrRequest, String collection)
private void decorateRequest(Request req, SolrRequest<?> solrRequest) {
req.header(HttpHeader.ACCEPT_ENCODING, null);
- req.timeout(idleTimeout, TimeUnit.MILLISECONDS);
+ if (requestTimeout > 0) {
Review Comment:
I don't think it makes much difference. 0 means timeout disabled, but our client will only wait for `idleTimeout` (see `listener.get(idleTimeout, TimeUnit.MILLISECONDS);`), so we'll timeout anyway, and at that point, probably better to timeout the request, since the client won't consume it anyway. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org