You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/08 09:58:11 UTC
[GitHub] [flink] paul8263 opened a new pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
paul8263 opened a new pull request #16108:
URL: https://github.com/apache/flink/pull/16108
…with "Address already in use"
## What is the purpose of the change
Fixed the issue that FlinkKafkaProducerMigrationTest fails with "Address already in use".
## Brief change log
- flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718)
* 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718)
* 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769)
* 850a2914588ba4bf362f5b800a053708c32bac22 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
}, {
"hash" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920",
"triggerID" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "03e33a13e8826f6cda49070c16679533f1223e94",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "994342748",
"triggerType" : "MANUAL"
}, {
"hash" : "b77db664216ddf6e88f2f663e08e7390809a24df",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28231",
"triggerID" : "b77db664216ddf6e88f2f663e08e7390809a24df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b77db664216ddf6e88f2f663e08e7390809a24df Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764715170
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import org.apache.flink.annotation.Internal;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple threads/processes. */
+@Internal
+public class FileLock {
+ private static final String TEMP_DIR = System.getProperty("java.io.tmpdir");
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ /**
+ * Initialize a FileLock using a file located at fullPath.
+ *
+ * @param fullPath The path of the locking file
+ */
+ public FileLock(String fullPath) {
+ Preconditions.checkNotNull(fullPath, "fullPath should not be null");
+ Path path = Paths.get(fullPath);
+ String normalizedFileName = normalizeFileName(path.getFileName().toString());
+ if (normalizedFileName.isEmpty()) {
+ throw new IllegalArgumentException("There are no legal characters in the file name");
+ }
+ this.file =
+ path.getParent() == null
+ ? new File(normalizedFileName)
+ : new File(path.getParent().toString(), normalizedFileName);
+ }
+
+ /**
+ * Initialize a FileLock using a file located at parentDir/fileName.
+ *
+ * @param parentDir The parent dir of the locking file
+ * @param fileName The name of the locking file
+ */
+ public FileLock(String parentDir, String fileName) {
+ Preconditions.checkNotNull(parentDir, "parentDir should not be null");
+ Preconditions.checkNotNull(fileName, "fileName should not be null");
+ this.file = new File(parentDir, normalizeFileName(fileName));
+ }
+
+ /**
+ * Initialize a FileLock using a file located inside temp folder.
+ *
+ * @param fileName The name of the locking file
+ * @return The initialized FileLock
+ */
+ public static FileLock inTempFolder(String fileName) {
+ return new FileLock(TEMP_DIR, fileName);
+ }
+
+ /**
+ * Check whether the locking file exists in the file system. Create it if it does not exist.
+ * Then create a FileOutputStream for it.
+ *
+ * @throws IOException If the file path is invalid or the parent dir does not exist
+ */
+ private void init() throws IOException {
+ if (!this.file.exists()) {
+ this.file.createNewFile();
+ }
+ outputStream = new FileOutputStream(this.file);
+ }
+
+ /**
+ * Try to acquire a lock on the locking file. This method immediately returns whenever the lock
+ * is acquired or not.
+ *
+ * @return True if successfully acquired the lock
+ * @throws IOException If the file path is invalid
+ */
+ public boolean tryLock() throws IOException {
+ if (outputStream == null) {
+ init();
+ }
+ try {
+ lock = outputStream.getChannel().tryLock();
+ } catch (Exception e) {
+ return false;
+ }
+
+ return lock != null;
+ }
+
+ /**
+ * Release the file lock.
+ *
+ * @throws IOException If the FileChannel is closed
+ */
+ public void unlock() throws IOException {
+ if (lock != null && lock.channel().isOpen()) {
+ lock.release();
+ }
+ }
Review comment:
This could also be inlined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-993790738
> Hi @AHeise , I don't know the file length limit is 3000. To avoid this, before every commit what I should run are spoltless:apply and checkstyle:check. Is there anything else I should run?
>
> If there are more things I need to do, please comment below. Thanks.
Please add
```
<suppress files="TaskExecutorTest.java" checks="FileLength"/>
```
to <flinkdir>/tools/maven/suppressions-runtime.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-992211680
> @AHeise These tests seem reasonable on the first look, I don't personally see much of a value in splitting-up the file. We already suppress this check-style rule for different tests [1], so I'd suggest we do the same here.
>
> I'll bring it up as a discussion topic with the team to decide whether we want to follow up on this.
>
> [1] https://github.com/apache/flink/blob/master/tools/maven/suppressions-runtime.xml#L33
That's fine by me. I just want to ensure that we are not pushing it onto an external contributor for obvious reasons :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
}, {
"hash" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920",
"triggerID" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "03e33a13e8826f6cda49070c16679533f1223e94",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "994342748",
"triggerType" : "MANUAL"
}, {
"hash" : "b77db664216ddf6e88f2f663e08e7390809a24df",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b77db664216ddf6e88f2f663e08e7390809a24df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03e33a13e8826f6cda49070c16679533f1223e94 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137)
* b77db664216ddf6e88f2f663e08e7390809a24df UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764473296
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
Review comment:
Good idea. I ignored the importance of Unix/Windows file name validation. I will add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #16108:
URL: https://github.com/apache/flink/pull/16108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-991706544
The build fails because of
```
[ERROR] src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java:[1] (sizes) FileLength: File length is 3,003 lines (max allowed is 3,000).
```
The real solution is to split the test but it doesn't make sense for you to do it since you barely touch the test. @dmvk could you please find someone to refactor the test into smaller chunks?
For now, we can just try to get rid of 3 lines to make the test pass.
```
@Rule public final TestName testName = new TestName();
```
Is unused and saves 2 lines. Maybe you can find one more line in your added code...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-991706900
One more thing: could you please update PR title, PR description, and commit message to reflect that you are actually stabilizing `NetUtils#getAvailablePort`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r770268401
##########
File path: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java
##########
@@ -102,10 +102,11 @@ public void setUp() throws Exception {
env.generateSequence(1, 1000).output(new DiscardingOutputFormat<>());
plan = env.createProgramPlan();
- final int freePort = NetUtils.getAvailablePort();
config = new Configuration();
config.setString(JobManagerOptions.ADDRESS, "localhost");
- config.setInteger(JobManagerOptions.PORT, freePort);
+ try (NetUtils.Port port = NetUtils.getAvailablePort()) {
Review comment:
Thanks. I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r770266892
##########
File path: flink-core/src/main/java/org/apache/flink/util/NetUtils.java
##########
@@ -498,4 +503,33 @@ public static boolean isValidClientPort(int port) {
public static boolean isValidHostPort(int port) {
return 0 <= port && port <= 65535;
}
+
+ /**
+ * Port wrapper class which holds a {@link FileLock} until it releases. Used to avoid race
+ * condition among multiple threads/processes.
+ */
+ public static class Port implements AutoCloseable {
+ private final int port;
+ private final FileLock fileLock;
+
+ public Port(int port, FileLock fileLock) throws IOException {
+ Preconditions.checkNotNull(fileLock, "FileLock should not be null");
+ Preconditions.checkState(fileLock.isValid(), "FileLock should be locked");
+ this.port = port;
+ this.fileLock = fileLock;
+ }
+
+ public int getPort() {
+ return port;
+ }
+
+ public void release() throws IOException {
+ fileLock.unlockAndDestroy();
+ }
Review comment:
OK. I'll inline it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r769387280
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import org.apache.flink.annotation.Internal;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple threads/processes. */
+@Internal
+public class FileLock {
+ private static final String TEMP_DIR = System.getProperty("java.io.tmpdir");
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ /**
+ * Initialize a FileLock using a file located at fullPath.
+ *
+ * @param fullPath The path of the locking file
+ */
+ public FileLock(String fullPath) {
+ Preconditions.checkNotNull(fullPath, "fullPath should not be null");
+ Path path = Paths.get(fullPath);
+ String normalizedFileName = normalizeFileName(path.getFileName().toString());
+ if (normalizedFileName.isEmpty()) {
+ throw new IllegalArgumentException("There are no legal characters in the file name");
+ }
+ this.file =
+ path.getParent() == null
+ ? new File(normalizedFileName)
+ : new File(path.getParent().toString(), normalizedFileName);
+ }
+
+ /**
+ * Initialize a FileLock using a file located at parentDir/fileName.
+ *
+ * @param parentDir The parent dir of the locking file
+ * @param fileName The name of the locking file
+ */
+ public FileLock(String parentDir, String fileName) {
+ Preconditions.checkNotNull(parentDir, "parentDir should not be null");
+ Preconditions.checkNotNull(fileName, "fileName should not be null");
+ this.file = new File(parentDir, normalizeFileName(fileName));
+ }
+
+ /**
+ * Initialize a FileLock using a file located inside temp folder.
+ *
+ * @param fileName The name of the locking file
+ * @return The initialized FileLock
+ */
+ public static FileLock inTempFolder(String fileName) {
+ return new FileLock(TEMP_DIR, fileName);
+ }
+
+ /**
+ * Check whether the locking file exists in the file system. Create it if it does not exist.
+ * Then create a FileOutputStream for it.
+ *
+ * @throws IOException If the file path is invalid or the parent dir does not exist
+ */
+ private void init() throws IOException {
+ if (!this.file.exists()) {
+ this.file.createNewFile();
+ }
+ outputStream = new FileOutputStream(this.file);
+ }
+
+ /**
+ * Try to acquire a lock on the locking file. This method immediately returns whenever the lock
+ * is acquired or not.
+ *
+ * @return True if successfully acquired the lock
+ * @throws IOException If the file path is invalid
+ */
+ public boolean tryLock() throws IOException {
+ if (outputStream == null) {
+ init();
+ }
+ try {
+ lock = outputStream.getChannel().tryLock();
+ } catch (Exception e) {
+ return false;
+ }
+
+ return lock != null;
+ }
+
+ /**
+ * Release the file lock.
+ *
+ * @throws IOException If the FileChannel is closed
+ */
+ public void unlock() throws IOException {
+ if (lock != null && lock.channel().isOpen()) {
+ lock.release();
+ }
+ }
Review comment:
Tests within a class are never executed in parallel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718)
* 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769)
* 850a2914588ba4bf362f5b800a053708c32bac22 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 850a2914588ba4bf362f5b800a053708c32bac22 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774)
* d7d66d77b7ac632cee04bfe17c7671e048535fc1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r763230150
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/FileLock.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.kafka.testutils;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private final String fileName;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) throws Exception {
+ this.fileName = fileName;
Review comment:
The lock is currently locking on the test name. However, the resource under contention is actually the port number.
So I propose that `NetUtils#getAvailablePort` determines a free port and if it finds any, it adds a lock to it (using some new `tryLock`). If that doesn't work, `getAvailablePort` just tries the next free port and repeats.
To unlock the port, you probably need to add a first-class object `Port` or `RandomPort` that implements `AutoClosable` and which then releases the owned file lock.
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
##########
@@ -125,7 +126,13 @@ public void prepare(Config config) throws Exception {
zookeeper = null;
brokers.clear();
+ // Use a file lock to avoid race condition when creating and starting Zookeeper
+ // TestingServer, which may lead to java.net.BindException: Address already in use.
+ FileLock fileLock = new FileLock(getClass().getName() + "fileLock");
Review comment:
I think the FileLock should be moved into `NetUtils#getAvailablePort` as this is the actual source of the port. As it's now, other test that use that function are circumventing your lock and let the job fail with the same error. Ideally, you can temporarily change `getAvailablePort` to return a constant port and the tests should still pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-992200780
@AHeise These tests seem reasonable on the first look, I don't personally see much of a value in splitting-up the file. We already suppress this check-style rule for different tests [1], so I'd suggest we do the same here.
I'll bring it up as a discussion topic with the team to decide whether we want to follow up on this.
[1] https://github.com/apache/flink/blob/master/tools/maven/suppressions-runtime.xml#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782)
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
paul8263 commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-993266073
Hi @AHeise ,
I don't know the file length limit is 3000. To avoid this, before every commit what I should run are spoltless:apply and checkstyle:check. Is there anything else I should run?
If there are more things I need to do, please comment below. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
}, {
"hash" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920",
"triggerID" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "03e33a13e8826f6cda49070c16679533f1223e94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cc9790481b8459c816d5750b08d8c8c4d5bbd26 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920)
* 03e33a13e8826f6cda49070c16679533f1223e94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
paul8263 commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-994342748
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764035150
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
+ }
+
+ private void init() throws IOException {
+ String filePath =
+ Paths.get(System.getProperty("java.io.tmpdir"), file.getName()).toString();
+ File lockFile = new File(filePath);
+ if (!lockFile.exists()) {
+ lockFile.createNewFile();
+ }
+
+ outputStream = new FileOutputStream(lockFile);
+ }
Review comment:
This method optimizes the repeated acquisition of the same lock. But do we even have that?
I'm worried that have a few race conditions here, we two processes try to acquire the lock at the same time.
Consider this case: Both processes don't see a file, the first one creates the file, the second one has an `IOException` on `createNewFile`.
I think I'd inline everything in `tryLock` and use the existing try-catch-block also for file creation and `unlockAndDestroy` (which could be simply `AutoCloseable#close`).
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
+ }
+
+ private void init() throws IOException {
+ String filePath =
+ Paths.get(System.getProperty("java.io.tmpdir"), file.getName()).toString();
+ File lockFile = new File(filePath);
+ if (!lockFile.exists()) {
+ lockFile.createNewFile();
+ }
+
+ outputStream = new FileOutputStream(lockFile);
+ }
+
+ public void lock() throws IOException {
Review comment:
Do we still need this method?
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
Review comment:
Can you please add `@Internal` for now.
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
+ }
+
+ private void init() throws IOException {
+ String filePath =
+ Paths.get(System.getProperty("java.io.tmpdir"), file.getName()).toString();
+ File lockFile = new File(filePath);
+ if (!lockFile.exists()) {
+ lockFile.createNewFile();
+ }
+
+ outputStream = new FileOutputStream(lockFile);
+ }
+
+ public void lock() throws IOException {
+ if (outputStream == null) {
+ init();
+ }
+ try {
+ lock = outputStream.getChannel().lock();
+ } catch (OverlappingFileLockException e) {
+ try {
+ Thread.sleep(TRY_LOCK_INTERVAL);
+ } catch (InterruptedException ignored) {
+ }
+ lock();
Review comment:
This could easily lead to a stack overflow.
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
Review comment:
Here we should simply pass `file` directly and just perform a `checkNotNull`.
We should then add a factory method
```
static FileLock inTempFolder(String fileName) {
return new File(System.getProperty("java.io.tmpdir"), fileName);
}
```
Maybe we should cache `System.getProperty("java.io.tmpdir")` in some constant `FileLock#TEMP_FOLDER`.
Lastly, do we need to strip `fileName` of illegal characters? I think `$` is a valid java class part but will lead to issues on some platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764519129
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
+ }
+
+ private void init() throws IOException {
+ String filePath =
+ Paths.get(System.getProperty("java.io.tmpdir"), file.getName()).toString();
+ File lockFile = new File(filePath);
+ if (!lockFile.exists()) {
+ lockFile.createNewFile();
+ }
+
+ outputStream = new FileOutputStream(lockFile);
+ }
+
+ public void lock() throws IOException {
+ if (outputStream == null) {
+ init();
+ }
+ try {
+ lock = outputStream.getChannel().lock();
+ } catch (OverlappingFileLockException e) {
+ try {
+ Thread.sleep(TRY_LOCK_INTERVAL);
+ } catch (InterruptedException ignored) {
+ }
+ lock();
Review comment:
Yes, it should be wrapped in a while clause instead of a recursive invocation. I will remove the lock method because we don't need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764519555
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
Review comment:
I added a normalization method which only allows letters, slashes and backslashes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7d66d77b7ac632cee04bfe17c7671e048535fc1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r763838385
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
##########
@@ -125,7 +126,13 @@ public void prepare(Config config) throws Exception {
zookeeper = null;
brokers.clear();
+ // Use a file lock to avoid race condition when creating and starting Zookeeper
+ // TestingServer, which may lead to java.net.BindException: Address already in use.
+ FileLock fileLock = new FileLock(getClass().getName() + "fileLock");
Review comment:
Hi @AHeise ,
I moved the FlieLock to flink core within the same package as NetUtils and created a class named Port, which holds a port and FileLock. The FileLock would be automatically unlocked with the help of AutoClosable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856635953
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7dfa9f7b6a707e25f0857f19629236e48801bc5b (Tue Jun 08 10:01:07 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-22821).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
}, {
"hash" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920",
"triggerID" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "03e33a13e8826f6cda49070c16679533f1223e94",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "994342748",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 03e33a13e8826f6cda49070c16679533f1223e94 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r762725154
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
##########
@@ -125,7 +125,10 @@ public void prepare(Config config) throws Exception {
zookeeper = null;
brokers.clear();
- zookeeper = new TestingServer(-1, tmpZkDir);
+ synchronized (KafkaTestEnvironmentImpl.class) {
+ zookeeper = new TestingServer(-1, tmpZkDir);
+ }
+
Review comment:
Thank you for your advice @AHeise , I implemented a file lock to avoid race condition among multiple unit test processes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764562387
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
+ }
+
+ private void init() throws IOException {
+ String filePath =
+ Paths.get(System.getProperty("java.io.tmpdir"), file.getName()).toString();
+ File lockFile = new File(filePath);
+ if (!lockFile.exists()) {
+ lockFile.createNewFile();
+ }
+
+ outputStream = new FileOutputStream(lockFile);
+ }
Review comment:
Hi @AHeise ,
`IOException` might not be thrown if the file already exists. We would get this exception if the parent directory of the file has not been created.
Sorry that I messed up the code while I was testing the snipped somewhere else. There is no need to create another `lockFile`.
I reconsidered the `tryLock` issue. I think the lock releasing/destroying should be outside `tryLock` and explicitly called even if failed to acquire the lock.
Correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764472462
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
+ private static final long TRY_LOCK_INTERVAL = 50;
+ private final File file;
+ private FileOutputStream outputStream;
+ private java.nio.channels.FileLock lock;
+
+ public FileLock(String fileName) {
+ this.file = new File(fileName);
+ }
+
+ private void init() throws IOException {
+ String filePath =
+ Paths.get(System.getProperty("java.io.tmpdir"), file.getName()).toString();
+ File lockFile = new File(filePath);
+ if (!lockFile.exists()) {
+ lockFile.createNewFile();
+ }
+
+ outputStream = new FileOutputStream(lockFile);
+ }
+
+ public void lock() throws IOException {
Review comment:
Yes. This method is still at risk because it would lead to stack overflow if it tried to lock too many times. If we have to use this lock method, I had better write it in a while clause.
But now it seems that we don't need the lock method so I plan to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
paul8263 commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-1010591513
Thank you @fapaul . I will do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
}, {
"hash" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920",
"triggerID" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03e33a13e8826f6cda49070c16679533f1223e94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6cc9790481b8459c816d5750b08d8c8c4d5bbd26 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920)
* 03e33a13e8826f6cda49070c16679533f1223e94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-898093270
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782)
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769)
* 850a2914588ba4bf362f5b800a053708c32bac22 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769)
* 850a2914588ba4bf362f5b800a053708c32bac22 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774)
* d7d66d77b7ac632cee04bfe17c7671e048535fc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a696994e8970d98e2f77aa7a4e1db93bb0ecbe53 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718)
* 5f040e7cb9eddcadd58fe0f37047c1fbd872512c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
paul8263 commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r764518525
##########
File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.util;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.nio.channels.OverlappingFileLockException;
+import java.nio.file.Paths;
+
+/** A file lock used for avoiding race condition among multiple unit test processes */
+public class FileLock {
Review comment:
I will add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dfa9f7b6a707e25f0857f19629236e48801bc5b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed9b4e968cb154ee4eaf5632c3bb89abb32781ad Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577)
* 850d89e857b2d45a1ae6477f55d9f9e310972ebc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r760025683
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
##########
@@ -125,7 +125,10 @@ public void prepare(Config config) throws Exception {
zookeeper = null;
brokers.clear();
- zookeeper = new TestingServer(-1, tmpZkDir);
+ synchronized (KafkaTestEnvironmentImpl.class) {
+ zookeeper = new TestingServer(-1, tmpZkDir);
+ }
+
Review comment:
This will probably not do anything. The issue is that multiple parallel processes are competing for the port on the same machine. Kafka tests are only executed non-parallel afaik, so there will never be 2 threads competing for the same port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f040e7cb9eddcadd58fe0f37047c1fbd872512c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769)
* 850a2914588ba4bf362f5b800a053708c32bac22 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774)
* d7d66d77b7ac632cee04bfe17c7671e048535fc1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
}, {
"hash" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920",
"triggerID" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "03e33a13e8826f6cda49070c16679533f1223e94",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "994342748",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 6cc9790481b8459c816d5750b08d8c8c4d5bbd26 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920)
* 03e33a13e8826f6cda49070c16679533f1223e94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r769390962
##########
File path: flink-core/src/main/java/org/apache/flink/util/NetUtils.java
##########
@@ -498,4 +503,33 @@ public static boolean isValidClientPort(int port) {
public static boolean isValidHostPort(int port) {
return 0 <= port && port <= 65535;
}
+
+ /**
+ * Port wrapper class which holds a {@link FileLock} until it releases. Used to avoid race
+ * condition among multiple threads/processes.
+ */
+ public static class Port implements AutoCloseable {
+ private final int port;
+ private final FileLock fileLock;
+
+ public Port(int port, FileLock fileLock) throws IOException {
+ Preconditions.checkNotNull(fileLock, "FileLock should not be null");
+ Preconditions.checkState(fileLock.isValid(), "FileLock should be locked");
+ this.port = port;
+ this.fileLock = fileLock;
+ }
+
+ public int getPort() {
+ return port;
+ }
+
+ public void release() throws IOException {
+ fileLock.unlockAndDestroy();
+ }
Review comment:
I'd inline this method into close. It's never directly called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16108:
URL: https://github.com/apache/flink/pull/16108#discussion_r769392660
##########
File path: flink-clients/src/test/java/org/apache/flink/client/program/ClientTest.java
##########
@@ -102,10 +102,11 @@ public void setUp() throws Exception {
env.generateSequence(1, 1000).output(new DiscardingOutputFormat<>());
plan = env.createProgramPlan();
- final int freePort = NetUtils.getAvailablePort();
config = new Configuration();
config.setString(JobManagerOptions.ADDRESS, "localhost");
- config.setInteger(JobManagerOptions.PORT, freePort);
+ try (NetUtils.Port port = NetUtils.getAvailablePort()) {
Review comment:
This should be `port = NetUtils.getAvailablePort()` where port is a field in the test class. In a `@After` you'd then call `port.close()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-993793059
Btw you also need to rebase onto master, to resolve the conflict in `KafkaTestEnvironmentImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][core] Stabilize NetUtils#getAvailablePort in order to avoid wrongly allocating any used ports
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"triggerType" : "PUSH"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22037",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "7dfa9f7b6a707e25f0857f19629236e48801bc5b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18782",
"triggerID" : "898093270",
"triggerType" : "MANUAL"
}, {
"hash" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27577",
"triggerID" : "ed9b4e968cb154ee4eaf5632c3bb89abb32781ad",
"triggerType" : "PUSH"
}, {
"hash" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27707",
"triggerID" : "850d89e857b2d45a1ae6477f55d9f9e310972ebc",
"triggerType" : "PUSH"
}, {
"hash" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27718",
"triggerID" : "a696994e8970d98e2f77aa7a4e1db93bb0ecbe53",
"triggerType" : "PUSH"
}, {
"hash" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27769",
"triggerID" : "5f040e7cb9eddcadd58fe0f37047c1fbd872512c",
"triggerType" : "PUSH"
}, {
"hash" : "850a2914588ba4bf362f5b800a053708c32bac22",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27774",
"triggerID" : "850a2914588ba4bf362f5b800a053708c32bac22",
"triggerType" : "PUSH"
}, {
"hash" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27777",
"triggerID" : "d7d66d77b7ac632cee04bfe17c7671e048535fc1",
"triggerType" : "PUSH"
}, {
"hash" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27920",
"triggerID" : "6cc9790481b8459c816d5750b08d8c8c4d5bbd26",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "03e33a13e8826f6cda49070c16679533f1223e94",
"triggerType" : "PUSH"
}, {
"hash" : "03e33a13e8826f6cda49070c16679533f1223e94",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137",
"triggerID" : "994342748",
"triggerType" : "MANUAL"
}, {
"hash" : "b77db664216ddf6e88f2f663e08e7390809a24df",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28231",
"triggerID" : "b77db664216ddf6e88f2f663e08e7390809a24df",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03e33a13e8826f6cda49070c16679533f1223e94 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28137)
* b77db664216ddf6e88f2f663e08e7390809a24df Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=28231)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16108:
URL: https://github.com/apache/flink/pull/16108#issuecomment-991706544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org