You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/06/26 09:17:51 UTC

[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2545: ci(bindings/swift): optimize time consumption of CI pipeline

Xuanwo commented on code in PR #2545:
URL: https://github.com/apache/incubator-opendal/pull/2545#discussion_r1241879419


##########
bindings/swift/Makefile:
##########
@@ -23,20 +23,26 @@ INCLUDE_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/include
 LIB_DIR=$(SWIFT_PKG_DIR)/Sources/COpenDAL/lib
 DIRS=$(INCLUDE_DIR) $(LIB_DIR)
 
+CARGO_FLAGS=--release

Review Comment:
   I prefer to keep makefiles as simple as possible and avoid using many arguments. When necessary, I would rather write a new `release` target instead of maintaining complex makefiles.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org