You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/30 03:29:26 UTC
[GitHub] [shardingsphere] edidada opened a new pull request #5391: resolve issue 5289
edidada opened a new pull request #5391:
URL: https://github.com/apache/shardingsphere/pull/5391
Fixes #5289.
Changes proposed in this pull request:
- this issue for new
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #5391: resolve issue 5289
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #5391:
URL: https://github.com/apache/shardingsphere/pull/5391#issuecomment-621608663
Hi @edidada
It is a better one, which has been a part of the master branch! :smiley
BTW, **do you think #5381 is stale one? If so, please close it.**
Another tip for you, when you want to give more new commits to the first PR, you can just commit your changes locally, and the GitHub will help synchronize your latest commits to the early PR. That is, a new PR is not required. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #5391: resolve issue 5289
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #5391:
URL: https://github.com/apache/shardingsphere/pull/5391#issuecomment-621608663
Hi @edidada
It is a better one, which has been a part of the master branch! π
BTW, **do you think #5381 is stale one? If so, please close it.**
Another tip for you, when you want to give more new commits to the first PR, you can just commit your changes locally, and the GitHub will help synchronize your latest commits to the early PR. That is, a new PR is not required. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5391: resolve issue 5289
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5391:
URL: https://github.com/apache/shardingsphere/pull/5391#issuecomment-621596697
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5391?src=pr&el=h1) Report
> Merging [#5391](https://codecov.io/gh/apache/shardingsphere/pull/5391?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/42b0d621333e10828a0ae7ea5bbba3a59f769a51&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5391?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5391 +/- ##
=========================================
Coverage 54.02% 54.02%
Complexity 412 412
=========================================
Files 1150 1150
Lines 20717 20717
Branches 3754 3754
=========================================
Hits 11192 11192
Misses 8812 8812
Partials 713 713
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5391?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5391?src=pr&el=footer). Last update [42b0d62...f849b51](https://codecov.io/gh/apache/shardingsphere/pull/5391?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5391: resolve issue 5289
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5391:
URL: https://github.com/apache/shardingsphere/pull/5391#issuecomment-621597450
## Pull Request Test Coverage Report for [Build 11360](https://coveralls.io/builds/30451737)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.528%**
---
| Totals | [](https://coveralls.io/builds/30451737) |
| :-- | --: |
| Change from base [Build 11359](https://coveralls.io/builds/30451183): | 0.0% |
| Covered Lines: | 11918 |
| Relevant Lines: | 20717 |
---
##### π - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #5391: resolve issue 5289
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #5391:
URL: https://github.com/apache/shardingsphere/pull/5391#issuecomment-621608663
Hi @edidada
It is a better one, which has been a part of the master branch!
BTW, **do you think #5381 is stale one? If so, please close it.**
Another tip for you, when you want to give more new commits to the first PR, you can just commit your changes locally, and the GitHub will help synchronize your latest commits to the early PR. That is, a new PR is not required. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org