You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "tomighita (via GitHub)" <gi...@apache.org> on 2026/03/05 16:14:14 UTC
[PR] Add integration test for message deduplicatpr [iggy]
tomighita opened a new pull request, #2879:
URL: https://github.com/apache/iggy/pull/2879
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2872
## Rationale
<!--
Why is this change needed? If the issue explains it well, a one-liner is fine.
-->
As stated in the issue description, the message deduplicator was lacking integration tests. This change adds one based on existing test harness.
## What changed?
<!--
2-4 sentences. Problem first (before), then solution (after).
GOOD:
"Messages were unavailable when background message_saver committed the
journal and started async disk I/O before completion. Polling during
this window found neither journal nor disk data.
The fix freezes journal batches in the in-flight buffer before async persist."
GOOD:
"When many small messages accumulate in the journal, the flush passes
thousands of IO vectors to writev(), exceeding IOV_MAX (1024 on Linux)."
BAD:
- Walls of text
- "This PR adds..." (we can see the diff)
-->
The message deduplicator is only tested through unit tests, which means it lacks end to end verification. This PR adds one integration test, covering common scenarios like:
- Add messages with new ids
- Add messages with existing ids
- Add messages where some of the ids exist
- Add messages after the TTL expired and ensure we can insert duplicate ids
## Local Execution
- Passed
- Pre-commit hooks ran
<!--
You must run your code locally before submitting.
"Relying on CI" is not acceptable - PRs from authors who haven't run the code will be closed.
Did you have `prek` installed? It runs automatically on commit and covers all project languages. See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md).
-->
## AI Usage
<!--
If AI tools were used, please answer:
1. Which tools? (e.g., GitHub Copilot, Claude, ChatGPT)
2. Scope of usage? (e.g., autocomplete, generated functions, entire implementation)
3. How did you verify the generated code works correctly?
4. Can you explain every line of the code if asked?
If no AI tools were used, write "None" or delete this section.
-->
1. Which tools: copilot cli
2. Scope of usage: repo onboarding, explaining concepts and architecture and generating test scaffold
3. How did you verify the generated code works correctly: ran the test
4. Can you explain every line of the code if asked: yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "tomighita (via GitHub)" <gi...@apache.org>.
tomighita commented on code in PR #2879:
URL: https://github.com/apache/iggy/pull/2879#discussion_r2908040498
##########
core/server/src/shard/system/messages.rs:
##########
@@ -356,6 +356,10 @@ impl IggyShard {
)
.await;
+ if batch.count() == 0 {
+ return Ok(());
+ }
Review Comment:
Isn’t this exactly what the step does where all ids are overlapping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add integration test for message deduplicatpr [iggy]
Posted by "tomighita (via GitHub)" <gi...@apache.org>.
tomighita commented on code in PR #2879:
URL: https://github.com/apache/iggy/pull/2879#discussion_r2891013602
##########
core/server/src/shard/system/partitions.rs:
##########
@@ -280,13 +281,15 @@ impl IggyShard {
)
});
+ let message_deduplicator = create_message_deduplicator(&self.config.system).map(Arc::new);
+
let partition = LocalPartition::with_log(
loaded_log,
stats,
std::sync::Arc::new(std::sync::atomic::AtomicU64::new(current_offset)),
consumer_offsets,
consumer_group_offsets,
- None,
+ message_deduplicator,
Review Comment:
[note] I've added this here since the message_deduplicator was always None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "atharvalade (via GitHub)" <gi...@apache.org>.
atharvalade commented on PR #2879:
URL: https://github.com/apache/iggy/pull/2879#issuecomment-4015508248
I found no critical issues in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2879:
URL: https://github.com/apache/iggy/pull/2879#discussion_r2923867415
##########
core/server/src/shard/system/messages.rs:
##########
@@ -356,6 +356,10 @@ impl IggyShard {
)
.await;
+ if batch.count() == 0 {
+ return Ok(());
+ }
Review Comment:
you're right, step 1 does hit that path - my bad, sorry. still, it'd be nice to have it as its own explicit step so it's obvious we're regression-testing that specific fix, not just as a side effect of the dedupcheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio closed pull request #2879: feat(server): Add integration test for message deduplicatpr
URL: https://github.com/apache/iggy/pull/2879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add integration test for message deduplicatpr [iggy]
Posted by "tomighita (via GitHub)" <gi...@apache.org>.
tomighita commented on code in PR #2879:
URL: https://github.com/apache/iggy/pull/2879#discussion_r2891011529
##########
core/server/src/shard/system/messages.rs:
##########
@@ -356,6 +356,10 @@ impl IggyShard {
)
.await;
+ if batch.count() == 0 {
+ return Ok(());
+ }
+
Review Comment:
[note] This was causing a bug when all the messages were with duplicate IDs because the batch was empty and we unwraped on first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2879:
URL: https://github.com/apache/iggy/pull/2879#issuecomment-4133734397
@tomighita do you plan to continue work on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on PR #2879:
URL: https://github.com/apache/iggy/pull/2879#issuecomment-4152680634
Closing due to inactivity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2879:
URL: https://github.com/apache/iggy/pull/2879#issuecomment-4107346840
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.
If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.
Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(server): Add integration test for message deduplicatpr [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2879:
URL: https://github.com/apache/iggy/pull/2879#discussion_r2907457884
##########
core/integration/tests/server/scenarios/message_deduplication_scenario.rs:
##########
@@ -0,0 +1,187 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::server::scenarios::{PARTITION_ID, STREAM_NAME, TOPIC_NAME, cleanup};
+use bytes::Bytes;
+use iggy::prelude::*;
+use integration::harness::{TestHarness, assert_clean_system};
+
+const MESSAGES_PER_BATCH: u32 = 10;
+
+pub async fn run(harness: &TestHarness) {
+ let client = harness
+ .root_client()
+ .await
+ .expect("Failed to get root client");
+ init_system(&client).await;
+
+ // Step 1: Duplicate rejection
+ // Send messages with IDs 1..`MESSAGES_PER_BATCH`, then resend the same IDs.
+ // Only the first batch should be persisted.
+ let mut original_messages = build_messages(1, MESSAGES_PER_BATCH, "original");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut original_messages,
+ )
+ .await
+ .unwrap();
+
+ let mut duplicate_messages = build_messages(1, MESSAGES_PER_BATCH, "duplicate");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut duplicate_messages,
+ )
+ .await
+ .unwrap();
+
+ let polled = poll_all(&client, MESSAGES_PER_BATCH * 2).await;
+ assert_eq!(
+ polled.messages.len() as u32,
+ MESSAGES_PER_BATCH,
+ "Duplicate messages should have been dropped"
+ );
+ for msg in &polled.messages {
+ let payload = std::str::from_utf8(&msg.payload).unwrap();
+ assert!(
+ payload.starts_with("original"),
+ "Expected original payload, got: {payload}"
+ );
+ }
+
+ // Step 2: Unique messages pass through
+ // Send messages with new IDs (`MESSAGES_PER_BATCH`+1)..(`MESSAGES_PER_BATCH`*2) — these should all be accepted.
+ let mut new_messages = build_messages(MESSAGES_PER_BATCH + 1, MESSAGES_PER_BATCH, "new-unique");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut new_messages,
+ )
+ .await
+ .unwrap();
+
+ let polled = poll_all(&client, MESSAGES_PER_BATCH * 3).await;
+ assert_eq!(
+ polled.messages.len() as u32,
+ MESSAGES_PER_BATCH * 2,
+ "Unique messages should have been accepted"
+ );
+
+ // Step 3: Partial deduplication
+ // Send a batch where half the IDs are duplicates and half are new.
+ // IDs `overlap_id_start`..(`overlap_id_start`+`MESSAGES_PER_BATCH`):
+ // IDs `overlap_id_start`..(`MESSAGES_PER_BATCH`*2) already exist (from Step 2),
+ // IDs (`MESSAGES_PER_BATCH`*2+1)..(`overlap_id_start`+`MESSAGES_PER_BATCH`) are new.
+ let overlap_id_start = 16;
+ let total_after_step3 = MESSAGES_PER_BATCH + overlap_id_start - 1;
+ // Ensure the `overlap_id_start` is between two batches.
+ assert!(overlap_id_start > MESSAGES_PER_BATCH && overlap_id_start < 2 * MESSAGES_PER_BATCH);
+ let mut mixed_messages = build_messages(overlap_id_start, MESSAGES_PER_BATCH, "mixed");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut mixed_messages,
+ )
+ .await
+ .unwrap();
+
+ let polled = poll_all(&client, MESSAGES_PER_BATCH * 4).await;
+ assert_eq!(
+ polled.messages.len() as u32,
+ total_after_step3,
+ "Only new IDs from the mixed batch should have been accepted"
+ );
Review Comment:
steps 3 and 4 only check message counts but never verify payloads. step 1 does this correctly (checks for "original" prefix), but step 3 doesn't verify the 5 surviving messages are actually the new ones (ids 21-25 with "mixed" payload) andnot some other combination. same for step 4 -- should check "after-ttl" payloads. count-only assertions can pass even if the wrong messages are kept.
##########
core/server/src/shard/system/messages.rs:
##########
@@ -356,6 +356,10 @@ impl IggyShard {
)
.await;
+ if batch.count() == 0 {
+ return Ok(());
+ }
Review Comment:
i get that it's a fix, but you didn't test it. nothing in this test actually exercises it. you'd need a step that sends a batch where every message is a duplicate (e.g. resend ids 1-10 a third time without any new ids mixed in) and verify the server doesn't blow up and the message count stays the same.
##########
core/integration/tests/server/scenarios/message_deduplication_scenario.rs:
##########
@@ -0,0 +1,187 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::server::scenarios::{PARTITION_ID, STREAM_NAME, TOPIC_NAME, cleanup};
+use bytes::Bytes;
+use iggy::prelude::*;
+use integration::harness::{TestHarness, assert_clean_system};
+
+const MESSAGES_PER_BATCH: u32 = 10;
+
+pub async fn run(harness: &TestHarness) {
+ let client = harness
+ .root_client()
+ .await
+ .expect("Failed to get root client");
+ init_system(&client).await;
+
+ // Step 1: Duplicate rejection
+ // Send messages with IDs 1..`MESSAGES_PER_BATCH`, then resend the same IDs.
+ // Only the first batch should be persisted.
+ let mut original_messages = build_messages(1, MESSAGES_PER_BATCH, "original");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut original_messages,
+ )
+ .await
+ .unwrap();
+
+ let mut duplicate_messages = build_messages(1, MESSAGES_PER_BATCH, "duplicate");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut duplicate_messages,
+ )
+ .await
+ .unwrap();
+
+ let polled = poll_all(&client, MESSAGES_PER_BATCH * 2).await;
+ assert_eq!(
+ polled.messages.len() as u32,
+ MESSAGES_PER_BATCH,
+ "Duplicate messages should have been dropped"
+ );
Review Comment:
after dedup removes messages mid-batch, offsets and indexes get rebuilt via remove_messages(). you never verify that the polled messages actually have correct, contiguous offsets. a bug in the offset recalculation would be a silent data corruption issue and this test wouldn't catch it.
##########
core/integration/tests/server/scenarios/message_deduplication_scenario.rs:
##########
@@ -0,0 +1,187 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use crate::server::scenarios::{PARTITION_ID, STREAM_NAME, TOPIC_NAME, cleanup};
+use bytes::Bytes;
+use iggy::prelude::*;
+use integration::harness::{TestHarness, assert_clean_system};
+
+const MESSAGES_PER_BATCH: u32 = 10;
+
+pub async fn run(harness: &TestHarness) {
+ let client = harness
+ .root_client()
+ .await
+ .expect("Failed to get root client");
+ init_system(&client).await;
+
+ // Step 1: Duplicate rejection
+ // Send messages with IDs 1..`MESSAGES_PER_BATCH`, then resend the same IDs.
+ // Only the first batch should be persisted.
+ let mut original_messages = build_messages(1, MESSAGES_PER_BATCH, "original");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut original_messages,
+ )
+ .await
+ .unwrap();
+
+ let mut duplicate_messages = build_messages(1, MESSAGES_PER_BATCH, "duplicate");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut duplicate_messages,
+ )
+ .await
+ .unwrap();
+
+ let polled = poll_all(&client, MESSAGES_PER_BATCH * 2).await;
+ assert_eq!(
+ polled.messages.len() as u32,
+ MESSAGES_PER_BATCH,
+ "Duplicate messages should have been dropped"
+ );
+ for msg in &polled.messages {
+ let payload = std::str::from_utf8(&msg.payload).unwrap();
+ assert!(
+ payload.starts_with("original"),
+ "Expected original payload, got: {payload}"
+ );
+ }
+
+ // Step 2: Unique messages pass through
+ // Send messages with new IDs (`MESSAGES_PER_BATCH`+1)..(`MESSAGES_PER_BATCH`*2) — these should all be accepted.
+ let mut new_messages = build_messages(MESSAGES_PER_BATCH + 1, MESSAGES_PER_BATCH, "new-unique");
+ client
+ .send_messages(
+ &Identifier::named(STREAM_NAME).unwrap(),
+ &Identifier::named(TOPIC_NAME).unwrap(),
+ &Partitioning::partition_id(PARTITION_ID),
+ &mut new_messages,
+ )
+ .await
+ .unwrap();
+
+ let polled = poll_all(&client, MESSAGES_PER_BATCH * 3).await;
+ assert_eq!(
+ polled.messages.len() as u32,
+ MESSAGES_PER_BATCH * 2,
+ "Unique messages should have been accepted"
+ );
+
+ // Step 3: Partial deduplication
+ // Send a batch where half the IDs are duplicates and half are new.
+ // IDs `overlap_id_start`..(`overlap_id_start`+`MESSAGES_PER_BATCH`):
+ // IDs `overlap_id_start`..(`MESSAGES_PER_BATCH`*2) already exist (from Step 2),
+ // IDs (`MESSAGES_PER_BATCH`*2+1)..(`overlap_id_start`+`MESSAGES_PER_BATCH`) are new.
+ let overlap_id_start = 16;
+ let total_after_step3 = MESSAGES_PER_BATCH + overlap_id_start - 1;
+ // Ensure the `overlap_id_start` is between two batches.
+ assert!(overlap_id_start > MESSAGES_PER_BATCH && overlap_id_start < 2 * MESSAGES_PER_BATCH);
Review Comment:
overlap_id_start = 16 is a magic number and the formula `total_after_step3 = MESSAGES_PER_BATCH + overlap_id_start - 1` only works because ids happen to be contiguous from 1. consider deriving it from the actual unique id range, e.g. `let new_ids_in_mixed = (overlap_id_start + MESSAGES_PER_BATCH) - (2 * MESSAGES_PER_BATCH + 1)` or just computing the set difference explicitly. also `build_messages` uses 0-based `i` in the payload instead of the actual message id, which makes correlating payloads to ids harder than it needs to be.
##########
core/integration/tests/server/scenarios/message_deduplication_scenario.rs:
##########
Review Comment:
you never test id 0 (auto-generated ids). the server replaces 0 with a uuid before the dedup check (messages_batch_mut.rs:164-166), so sending multiple messages with id 0 should all pass through. without this, you could silently break the default send path and never know. after that, please also poll the messages to check whether they have unique message id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add integration test for message deduplicatpr [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2879:
URL: https://github.com/apache/iggy/pull/2879#issuecomment-4006749949
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2879?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.30%. Comparing base ([`6735eea`](https://app.codecov.io/gh/apache/iggy/commit/6735eea6bc8e30c889981e45ac4c881f56396d4e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e8ea671`](https://app.codecov.io/gh/apache/iggy/commit/e8ea67142a284be5aef3d6c42a19e811aa8cf9a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2879 +/- ##
============================================
- Coverage 68.33% 66.30% -2.03%
Complexity 739 739
============================================
Files 1052 977 -75
Lines 84745 78886 -5859
Branches 61281 61104 -177
============================================
- Hits 57910 52309 -5601
+ Misses 24463 24205 -258
Partials 2372 2372
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2879/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [node](https://app.codecov.io/gh/apache/iggy/pull/2879/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.29% <ø> (-4.99%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/2879?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/server/src/shard/system/messages.rs](https://app.codecov.io/gh/apache/iggy/pull/2879?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fshard%2Fsystem%2Fmessages.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL3NoYXJkL3N5c3RlbS9tZXNzYWdlcy5ycw==) | `89.18% <ø> (ø)` | |
| [core/server/src/shard/system/partitions.rs](https://app.codecov.io/gh/apache/iggy/pull/2879?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fshard%2Fsystem%2Fpartitions.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL3NoYXJkL3N5c3RlbS9wYXJ0aXRpb25zLnJz) | `84.48% <ø> (-0.07%)` | :arrow_down: |
... and [93 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2879/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org