You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/18 01:16:42 UTC

[GitHub] [spark] kariya-mitsuru opened a new pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

kariya-mitsuru opened a new pull request #31221:
URL: https://github.com/apache/spark/pull/31221


   ### What changes were proposed in this pull request?
   Fixing typos in the docs sql-ref-datatypes.md.
   
   ### Why are the changes needed?
   To display '<element_type>' correctly.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Manually run jekyll.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761976423


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38763/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31221:
URL: https://github.com/apache/spark/pull/31221#discussion_r559301101



##########
File path: docs/sql-ref-datatypes.md
##########
@@ -193,7 +193,7 @@ The following table shows the type names as well as aliases used in Spark SQL pa
 |**BinaryType**|BINARY|
 |**DecimalType**|DECIMAL, DEC, NUMERIC|
 |**CalendarIntervalType**|INTERVAL|
-|**ArrayType**|ARRAY<element_type>|
+|**ArrayType**|ARRAY\<element_type>|

Review comment:
       Oh, it thinks it's an XML.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761929834


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761987111


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38763/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] kariya-mitsuru commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
kariya-mitsuru commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761938894


   > Could you please attach screen captures in the description if possible?
   
   I have attached screen captures of before and after this fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761978692


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134179/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31221:
URL: https://github.com/apache/spark/pull/31221#discussion_r559300186



##########
File path: docs/sql-ref-datatypes.md
##########
@@ -193,7 +193,7 @@ The following table shows the type names as well as aliases used in Spark SQL pa
 |**BinaryType**|BINARY|
 |**DecimalType**|DECIMAL, DEC, NUMERIC|
 |**CalendarIntervalType**|INTERVAL|
-|**ArrayType**|ARRAY<element_type>|
+|**ArrayType**|ARRAY\<element_type>|

Review comment:
       Interesting .. why do we have to escape this alone?
   Looks good anyway as it works ..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761969161


   Merged to master, branch-3.1 and branch-3.0.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761968897


   Let me merge this one anyway. It looks good and approved by @kiszk and me but it would be great if we can know why (https://github.com/apache/spark/pull/31221#discussion_r559308104).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761963177


   **[Test build #134179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134179/testReport)** for PR 31221 at commit [`3b4698a`](https://github.com/apache/spark/commit/3b4698a6103e7727dfcf73097c2a2ce33070a129).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] kariya-mitsuru commented on a change in pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
kariya-mitsuru commented on a change in pull request #31221:
URL: https://github.com/apache/spark/pull/31221#discussion_r559623646



##########
File path: docs/sql-ref-datatypes.md
##########
@@ -193,7 +193,7 @@ The following table shows the type names as well as aliases used in Spark SQL pa
 |**BinaryType**|BINARY|
 |**DecimalType**|DECIMAL, DEC, NUMERIC|
 |**CalendarIntervalType**|INTERVAL|
-|**ArrayType**|ARRAY<element_type>|
+|**ArrayType**|ARRAY\<element_type>|

Review comment:
       This behavior comes from [kramdown](https://kramdown.gettalong.org/) which is used by Jekyll.
   
   The `element_type` is interpreted as an html tag because it consists of only alphabet characters.
   On the other hand, `field1_name: field1_type, field2_name: field2_type, ...`(STRUCT) and `key_type, value_type`(MAP) contain bare comma, so they cannot be interpreted as html tags.
   
   Strictly speaking, kramdown uses the following regular expression to determine whether it is an html tag or not.
   
   ```
   (?m-ix:<((?>(?:[[:alpha:]_][-[:alnum:]._]*:)?[[:alpha:]_][-[:alnum:]._]*))\\s*((?>\\s+(?:[[:alpha:]_][-[:alnum:]._]*:)?[[:alpha:]_][-[:alnum:]._]*(?:\\s*=\\s*(?:\\p{Word}+|(\"|').*?\\3))?)*)\\s*(\\/)?>)
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761929834


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] kiszk commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761932968


   Could you please attach screen captures in the description if possible?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #31221:
URL: https://github.com/apache/spark/pull/31221#discussion_r559301101



##########
File path: docs/sql-ref-datatypes.md
##########
@@ -193,7 +193,7 @@ The following table shows the type names as well as aliases used in Spark SQL pa
 |**BinaryType**|BINARY|
 |**DecimalType**|DECIMAL, DEC, NUMERIC|
 |**CalendarIntervalType**|INTERVAL|
-|**ArrayType**|ARRAY<element_type>|
+|**ArrayType**|ARRAY\<element_type>|

Review comment:
       Oh, it thinks it's an HTML.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31221:
URL: https://github.com/apache/spark/pull/31221


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] kiszk commented on a change in pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
kiszk commented on a change in pull request #31221:
URL: https://github.com/apache/spark/pull/31221#discussion_r559308104



##########
File path: docs/sql-ref-datatypes.md
##########
@@ -193,7 +193,7 @@ The following table shows the type names as well as aliases used in Spark SQL pa
 |**BinaryType**|BINARY|
 |**DecimalType**|DECIMAL, DEC, NUMERIC|
 |**CalendarIntervalType**|INTERVAL|
-|**ArrayType**|ARRAY<element_type>|
+|**ArrayType**|ARRAY\<element_type>|

Review comment:
       I am also curious about why `STRUCT` and `Map` do not require escape.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-762000095


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38763/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761957933


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761965991


   **[Test build #134179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134179/testReport)** for PR 31221 at commit [`3b4698a`](https://github.com/apache/spark/commit/3b4698a6103e7727dfcf73097c2a2ce33070a129).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761963177


   **[Test build #134179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134179/testReport)** for PR 31221 at commit [`3b4698a`](https://github.com/apache/spark/commit/3b4698a6103e7727dfcf73097c2a2ce33070a129).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-762000095


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38763/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31221: [MINOR][DOCS] Fix typos in sql-ref-datatypes.md

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31221:
URL: https://github.com/apache/spark/pull/31221#issuecomment-761978692


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134179/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org