You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/16 16:21:48 UTC
[GitHub] [flink] sv3ndk opened a new pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
sv3ndk opened a new pull request #14672:
URL: https://github.com/apache/flink/pull/14672
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*fix documentation mistake: the raw format is a built-in format distributed with blink-table-planner but was documented as a separate jar.*
## Brief change log
- *removed `flink-raw.jar` reference from `site-connector.yml`*
- *update the raw format documentation: no longer loads the `sql-connnector-download-table.html` snippet*
- *added maven xml format to connectors and format documentation for user convenience*
## Verifying this change
I manually ran `./build_docs.sh -p `, the format seems ok now.
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761591013
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe (Sat Jan 16 16:24:36 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761593893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12142",
"triggerID" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"triggerType" : "PUSH"
}, {
"hash" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12152",
"triggerID" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"triggerType" : "PUSH"
}, {
"hash" : "f1733387653ff03bd40a52b6fa8856027024fa1b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12158",
"triggerID" : "f1733387653ff03bd40a52b6fa8856027024fa1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1733387653ff03bd40a52b6fa8856027024fa1b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12158)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14672:
URL: https://github.com/apache/flink/pull/14672#discussion_r559191882
##########
File path: docs/dev/table/connectors/formats/raw.zh.md
##########
@@ -33,13 +33,7 @@ Raw format 允许读写原始（基于字节）值作为单个列。
注意: 这种格式将 `null` 值编码成 `byte[]` 类型的 `null`。这样在 `upsert-kafka` 中使用时可能会有限制，因为 `upsert-kafka` 将 `null` 值视为 墓碑消息（在键上删除）。因此，如果该字段可能具有 `null` 值，我们建议避免使用 `upsert-kafka` 连接器和 `raw` format 作为 `value.format`。
-依赖
-------------
-
-{% assign connector = site.data.sql-connectors['raw'] %}
-{% include sql-connector-download-table.zh.html
- connector=connector
-%}
+Raw format 连接器是内置的。
Review comment:
Cool translation ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #14672:
URL: https://github.com/apache/flink/pull/14672#discussion_r559220386
##########
File path: docs/dev/table/connectors/formats/raw.zh.md
##########
@@ -33,13 +33,7 @@ Raw format 允许读写原始（基于字节）值作为单个列。
注意: 这种格式将 `null` 值编码成 `byte[]` 类型的 `null`。这样在 `upsert-kafka` 中使用时可能会有限制，因为 `upsert-kafka` 将 `null` 值视为 墓碑消息（在键上删除）。因此，如果该字段可能具有 `null` 值，我们建议避免使用 `upsert-kafka` 连接器和 `raw` format 作为 `value.format`。
-依赖
-------------
-
-{% assign connector = site.data.sql-connectors['raw'] %}
-{% include sql-connector-download-table.zh.html
- connector=connector
-%}
+Raw format 连接器是内置的。
Review comment:
> I'm thinking about adding table border to it, like following, what do you think?
That's much clearer indeed, thanks for the suggestion.
> we should also update the Chinese version of the sql-connnector-download-table.html.
Sorry for having overlooked that one, and thanks for the commit, I copied here your update.
> Cool translation ;)
Thanks. I copy-pasted it from the "DataGen" connector, I don't speak Chinese myself unfortunately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-764426318
Thanks for the merge @wuchong
> Could you help to open a pull request for release-1.12 ?
Gladly. I'm new here so I want to make sure I do this correctly: all I should do is open another PR with the same commits to the branch called release-1.12, is this correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761593893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12142",
"triggerID" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"triggerType" : "PUSH"
}, {
"hash" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12152",
"triggerID" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"triggerType" : "PUSH"
}, {
"hash" : "f1733387653ff03bd40a52b6fa8856027024fa1b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f1733387653ff03bd40a52b6fa8856027024fa1b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50f142696f4553e0bf7742ef4b46be78f57461d6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12152)
* f1733387653ff03bd40a52b6fa8856027024fa1b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-764886576
There you go: https://github.com/apache/flink/pull/14723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14672:
URL: https://github.com/apache/flink/pull/14672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761593893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12142",
"triggerID" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"triggerType" : "PUSH"
}, {
"hash" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12142)
* 50f142696f4553e0bf7742ef4b46be78f57461d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761593893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-764388301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-764362584
Hi,
Do you need more input from me on this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-764388301
@sv3ndk , sorry, I do think I missed to merge this PR.
Could you help to open a pull request for release-1.12 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761593893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12142",
"triggerID" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-764362584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14672:
URL: https://github.com/apache/flink/pull/14672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761593893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12142",
"triggerID" : "c1ae8b92b6a0bec992e149b45b3ae6a58ffa92fe",
"triggerType" : "PUSH"
}, {
"hash" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12152",
"triggerID" : "50f142696f4553e0bf7742ef4b46be78f57461d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 50f142696f4553e0bf7742ef4b46be78f57461d6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12152)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-764445821
Yes, you are right. You can just cherry pick the merged commit to your dev branch based on latest release-1.12 branch. But you may need to resolve conflicts if there are conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #14672:
URL: https://github.com/apache/flink/pull/14672#discussion_r559220386
##########
File path: docs/dev/table/connectors/formats/raw.zh.md
##########
@@ -33,13 +33,7 @@ Raw format 允许读写原始（基于字节）值作为单个列。
注意: 这种格式将 `null` 值编码成 `byte[]` 类型的 `null`。这样在 `upsert-kafka` 中使用时可能会有限制，因为 `upsert-kafka` 将 `null` 值视为 墓碑消息（在键上删除）。因此，如果该字段可能具有 `null` 值，我们建议避免使用 `upsert-kafka` 连接器和 `raw` format 作为 `value.format`。
-依赖
-------------
-
-{% assign connector = site.data.sql-connectors['raw'] %}
-{% include sql-connector-download-table.zh.html
- connector=connector
-%}
+Raw format 连接器是内置的。
Review comment:
> I'm thinking about adding table border to it, like following, what do you think?
That's much clearer indeed, thanks for the suggestion.
> we should also update the Chinese version of the sql-connnector-download-table.html.
Sorry for having overlooked that one, and thanks for the commit, I copied here your update.
> Cool translation ;)
Thanks. I copy-pasted it from the "DataGen" connector, I don't speak Chinese myself unfortunately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14672: [FLINK-20998][docs] - flink-raw.jar no longer mentioned + prettier maven xml dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14672:
URL: https://github.com/apache/flink/pull/14672#issuecomment-761591013
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f1733387653ff03bd40a52b6fa8856027024fa1b (Fri May 28 07:11:52 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org