You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/18 09:19:18 UTC
[GitHub] [skywalking-swck] RolandMa1986 opened a new pull request #47: Remove deprecated Kubernetes API dependence
RolandMa1986 opened a new pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47
This PR includes the following change:
- Generate CRD with controller-gen 0.7.0 to update CRD API Version to apiextensions.k8s.io/v1
- Change cert-manager API Version cert-manager.io/v1, since the older v1alpha2 is no longer supported by cert-manange 1.x
- Change Ingress API version to networking.k8s.io/v1.
Reffer to apache/skywalking#8136
Signed-off-by: Roland.Ma <ro...@kubesphere.io>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-977581725
In the CI process, skywalking-eyes is activated for header checking. At here, https://github.com/apache/skywalking-eyes/tree/v0.2.0#resolve-dependencies-licenses, you could find out how to process license audit(manually).
Eventually, this file should be updated. https://github.com/apache/skywalking-swck/blob/master/dist/LICENSE#L203 including dependencies with licenses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-976222583
> > > How about keeping the lowest k8s version in the e2e testing? @hanahmily
> >
> >
> > the 1.19 used by e2e is the minimal version of most k8s vendor/orchestration support. The could vendor like GKE defaults to 1.21 now.
>
> Should we add 1.21 in the e2e too? After all, SWCK is much more k8s sensitive than other components.
it makes sense to me. @dashanji is on the last e2e case related to the hpa adapter. Once it's completed, we will assess which versions will be included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-974550339
Please notice License and dependency update. The SkyWalking eyes tool is ready for go dependency analysis.
Ping @kezhenxu94 if you face issues when use the tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] RolandMa1986 commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
RolandMa1986 commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-977473033
> @RolandMa1986 Thank you for your contribution. As I mentioned, we want to upgrade kubebuilder to v3. I would like to investigate the impact of the API update before reviewing it. Do you have some insights into this task?
@hanahmily I think Upgrade Kubebuilder to v3 doesn't have any conflict with this PR.
There are 3 parts that will be changed in the Kuberbuilder v3 according to the [upgrading guide](https://book.kubebuilder.io/migration/v2vsv3.html)
1. PROJECT file' layout. I'm sure what was changed exactly.
2. Scaffolded tools. The latest Kubebuilder v3.2.0 still uses `controller-tools 0.7.0` which is the same version used in SWCK. So I think that all the generated manifest will be the same.
3. Go mod dependence. For `controller-runtime` and `k8s.io/api`, I think it depends on which kubebuilder version was used when initializing the PROJECT. But in practice, we just need to consider which Kubernetes version we need to support and choose a compatible version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] RolandMa1986 commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
RolandMa1986 commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-977565988
> Notice, with dependency changed, we need to update license file of binary.
Is there any document that I can follow up on？ I don't know which file I need to change. The SkyWalking eyes result didn't show any tips:
```
INFO Loading configuration from file: .licenserc.yaml
INFO No config file is given, using the default config
INFO Totally checked 476 files, valid: 165, invalid: 0, ignored: 311, fixed: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-977474356
Notice, with dependency changed, we need to update license file of binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-974551287
@RolandMa1986 Thank you for your contribution. As I mentioned, we want to upgrade kubebuilder to v3. I would like to investigate the impact of the API update before reviewing it. Do you have some insights into this task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-976198663
How about keeping the lowest k8s version in the e2e testing? @hanahmily
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-976217905
> > How about keeping the lowest k8s version in the e2e testing? @hanahmily
>
> the 1.19 used by e2e is the minimal version of most k8s vendor/orchestration support. The could vendor like GKE defaults to 1.21 now.
Should we add 1.21 in the e2e too? After all, SWCK is much more k8s sensitive than other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily merged pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-977579675
> Notice, with dependency changed, we need to update license file of binary.
@RolandMa1986 has not changed/updated any dependencies in this.
And I will hold this PR until the coming metric adapter E2E ensure all components of SWCK with these changes work as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on pull request #47: Remove deprecated Kubernetes API dependence
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #47:
URL: https://github.com/apache/skywalking-swck/pull/47#issuecomment-976205575
> How about keeping the lowest k8s version in the e2e testing? @hanahmily
the 1.19 used by e2e is the minimal version of most k8s vendor/orchestration support. The could vendor like GKE defaults to 1.21 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org