[jira] [Comment Edited] (OAK-8769) oak-auth-ldap pom needs maintenance

["Manfred Baedke (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066696#comment-17066696 ] 

Manfred Baedke edited comment on OAK-8769 at 3/25/20, 2:41 PM:
---------------------------------------------------------------

Attached OAK-8769.patch. Summary of changes:

* removed test exclusions for Java 1.6
* Updated to org.apache.directory.api.api-all-2.0.0 (LDAP client API). That implies some minor code modifications because of incompatible API changes.
* Updated to org.apache.directory.server.apacheds-all-2.0.0-M24 (LDAP server used for testing). Unfortunately, this still uses older incompatible versions of some dependencies. Therefore the tests have been modified to use a separate ClassLoader to start and set up the server.
* Jacoco now measures a slightly lower coverage, though we run the same test set. I'll look into that (probably it's caused by the additional reflection we have to use now). For the attached patch I adjusted the expectations.
* disabled transitive embedding of the dependencies. That is probably not a good idea, I will do some tests.


was (Author: baedke):
Attached OAK-8769.patch. Summary of changes:

* removed test exclusions for Java 1.6
* Updated to org.apache.directory.api.api-all-2.0.0 (LDAP client API). That implies some minor code modifications because of incompatible API changes.
* Updated to org.apache.directory.server.apacheds-all-2.0.0-M24 (LDAP server used for testing). Unfortunately, this still uses older incompatible versions of some dependencies. Therefore the tests have been modified to use a separate ClassLoader to start and set up the server.
* Jacoco now measures a slightly lower coverage, though we run the same test set. I'll look into that. For the attached patch I adjusted the expectations.
* disabled transitive embedding of the dependencies. That is probably not a good idea, I will do some tests.

> oak-auth-ldap pom needs maintenance
> -----------------------------------
>
>                 Key: OAK-8769
>                 URL: https://issues.apache.org/jira/browse/OAK-8769
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-ldap
>            Reporter: Manfred Baedke
>            Assignee: Manfred Baedke
>            Priority: Minor
>         Attachments: OAK-8769-dep-updates.diff, OAK-8769.patch
>
>
> The oak-auth-ldap pom features some legacy aspects that could use rework:
>  * It defines a profile to disable certain tests for JDK1.6, which should be redundant now.
>  * It defines a configuration for the maven-bundle-plugin which
>  ** embeds dependencies, which might (at least for some) no longer be needed.
>  ** embeds the dependencies transitively. Maybe we can get rid of that.
>  ** has some obscure exclusions from the package imports.
> Also, some of the dependencies use outdated versions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)