You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/09/11 18:18:54 UTC

[kudu-CR](branch-1.17.x) KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Hello Zoltan Martonka, Yingchun Lai, Kudu Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/21791

to review the following change.


Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4
......................................................................

KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Per the root cause analysis outlined in another take [1] to address
the issue, it makes sense to limit the network stack of mini-ranger's
and mini-ranger-kms' JVM to IPv4.  With that and one more patch [2],
WaitForTcpBind() works as expected and two KMS-related scenarios of the
SecurityITest test now pass where they used to fail before.

[1] https://gerrit.cloudera.org/#/c/20514/
[2] https://gerrit.cloudera.org/#/c/20583/

Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Reviewed-on: http://gerrit.cloudera.org:8080/20582
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
(cherry picked from commit 19fbacfc3685b1ec2ed7f20c0dc22d4bd0618135)
---
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger/mini_ranger.cc
2 files changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/21791/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR](branch-1.17.x) KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21791 )

Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 18:45:30 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21791 )

Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/505/


-- 
To view, visit http://gerrit.cloudera.org:8080/21791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 18:19:02 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.

Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR](branch-1.17.x) KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21791 )

Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4
......................................................................

KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Per the root cause analysis outlined in another take [1] to address
the issue, it makes sense to limit the network stack of mini-ranger's
and mini-ranger-kms' JVM to IPv4.  With that and one more patch [2],
WaitForTcpBind() works as expected and two KMS-related scenarios of the
SecurityITest test now pass where they used to fail before.

[1] https://gerrit.cloudera.org/#/c/20514/
[2] https://gerrit.cloudera.org/#/c/20583/

Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Reviewed-on: http://gerrit.cloudera.org:8080/20582
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
(cherry picked from commit 19fbacfc3685b1ec2ed7f20c0dc22d4bd0618135)
Reviewed-on: http://gerrit.cloudera.org:8080/21791
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/ranger-kms/mini_ranger_kms.cc
M src/kudu/ranger/mini_ranger.cc
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Abhishek Chennaka: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR](branch-1.17.x) KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21791 )

Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/505/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 22:11:53 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21791 )

Change subject: KUDU-3507 instruct mini-ranger-{kms} JVM to use IPv4
......................................................................


Patch Set 1: Verified+1

Based on the tip of the chain


-- 
To view, visit http://gerrit.cloudera.org:8080/21791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f38a0b7df153108d7072a66813068a764e4e601
Gerrit-Change-Number: 21791
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 21:41:55 +0000
Gerrit-HasComments: No