You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/14 05:39:53 UTC

[GitHub] [apisix-helm-chart] Gallardot commented on a change in pull request #215: feat(apisix-dashboard): add etcd prefix

Gallardot commented on a change in pull request #215:
URL: https://github.com/apache/apisix-helm-chart/pull/215#discussion_r784518984



##########
File path: charts/apisix-dashboard/templates/configmap.yaml
##########
@@ -30,6 +30,7 @@ data:
         port: {{ .listen.port }}
       {{- with .etcd }}
       etcd:
+        prefix: {{ .prefix | quote }}

Review comment:
       
   > Could you also describe it in the README?
   
   @tokers @juzhiyuan 
   
   Maybe you mean something like this [configuration list description](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix#parameters)?  Maybe we can create another PR to handle this.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org