You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Jay Freeman (saurik)" <sa...@saurik.com> on 2001/11/17 11:29:26 UTC
'svn commit' fails with PROPPATCH error...
:(
OK, someone mind telling me what I am doing wrong here? :) What I'm
doing is so fundamental I can't believe it would be a bug.
I installed Apache 2.0b28 and the svn r464 from the website (which is
only 2 days old and is in some way a "release", so I figure that simple
things in it are still applicable to the latest code in the repository).
I added to my httpd.conf:
<Location /svn/repos>
DAV svn
SVNPath /cvs/svn
</Location>
The only other changes I made where to change the User/Group to
apache/apache, and to change the Listen port to 423 (as I already have
Apache 1.3.14 serving web pages on this computer). As for the /cvs,
/cvs is a partition which I have allocated for CVS :).
I then ran svnadmin on that directory and chown -R apache.apache
'd it. I was successfully able to do an svn co in another
directory, so I went ahead, touched a text file, and svn add 'd
it. So far, so good :-P. Then I went and tried to commit, and I got
the following error:
[root(3)@dreadnought repos]# svn commit
svn_error: #21075 : <RA layer's server request failed>
The log message's PROPPATCH request failed (neon: 1)
(/svn/repos/$svn/wbl/563007c8-d11d-b211-a84d-d794e2525663/0)
I checked the web server's error_log, and got the following:
[Sat Nov 17 02:55:00 2001] [error] [client 209.224.199.248] Could not
execute PROPPATCH. [500, #206]
[Sat Nov 17 02:55:00 2001] [error] [client 209.224.199.248] Properties
may only be defined in the svn: and svn:custom: namespaces. [409, #0]
I tried to chmod -R 777 /cvs/svn (as it was mentioned that many
errors might occur due to permission problems), but that didn't help
any. :(... confused...
I thought I'd at least try the latest copy before sending this e-mail,
so I svn'd out the latest svn, compiled it, and apxs'd it. Now Apache
won't even run :). I get:
[root(3)@dreadnought mod_dav_svn]# /usr/local/apache2/bin/apachectl
configtest
Syntax error on line 198 of /usr/local/apache2/conf/httpd.conf:
Cannot load /usr/local/apache2/modules/libmod_dav_svn.so into server:
/usr/local/apache2/modules/libmod_dav_svn.so: undefined symbol:
ap_get_module_config
Sincerely,
Jay Freeman (saurik)
saurik@saurik.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] Memory buffer misuse in deadprops.c (was: 'svn commit' fails with PROPPATCH error...)
Posted by "Jay Freeman (saurik)" <sa...@saurik.com>.
Well, I think I got it :). There is an extra variable (char
*tproppatch) that is being used in deadprops.c (uninitialized... I would
expect a warning to catch that... anyone looking at those things?) that
was supposed to be another one of a similar spelling (proppatch). When
you don't send a log message using -F or -m the server has the pointer
at 0x0, when you do it gets shoved forward to another region and tends
to get initialized to some low value. As the check that is misusing it
only compares it to NULL, this works in the cases where the log message
is there. Below is a patch to fix this (is there somewhere better I
should be sending stuff like this?).
Also, this reminded me of something: shouldn't it offer to open vi or
something if there isn't a log message specified using -F or -m?
Index: ./subversion/mod_dav_svn/deadprops.c
===================================================================
--- ./subversion/mod_dav_svn/.svn/text-base/deadprops.c.svn-base
Tue Nov 20 03:00:53 2001
+++ ./subversion/mod_dav_svn/deadprops.c Wed Nov 21 17:47:40 2001
@@ -119,14 +119,13 @@
{
char *propname;
svn_error_t *serr;
- char *tpropname;
/* get the repos-local name */
get_repos_propname(db, name, &propname);
/* ### disallow arbitrary, non-SVN properties. this effectively shuts
### off arbitrary DeltaV clients for now. */
- if (tpropname == NULL)
+ if (propname == NULL)
return dav_new_error(db->p, HTTP_CONFLICT, 0,
"Properties may only be defined in the "
SVN_PROP_PREFIX " and " SVN_PROP_CUSTOM_PREFIX
Sincerely,
Jay Freeman (saurik)
saurik@saurik.com
-----Original Message-----
From: Jay Freeman (saurik) [mailto:saurik@saurik.com]
Sent: Tuesday, November 20, 2001 3:44 AM
To: 'Greg Stein'
Cc: 'svn-dev'
Subject: RE: 'svn commit' fails with PROPPATCH error...
...
What can I do to help shed some light onto this?
Sincerely,
Jay Freeman (saurik)
saurik@saurik.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: 'svn commit' fails with PROPPATCH error...
Posted by "Jay Freeman (saurik)" <sa...@saurik.com>.
OK, it was just the opposite :). I didn't compile Apache with
--enable-maintainer-mode, so I went back and did that (debug sounded
useful considering this other problem).
I am now using revision 480 (deleted and re 'svnadmin create'd the
database, in case that was important), and am still getting the same
problem. Same message comes out (different GUID on the commit, of
course), and Apache is logging the same message.
*starts thinking about what other information he could give*
I configured Apache with:
--enable-dav --enable-maintainer-mode
I configured svn with:
--enable-maintainer-mode --with-axps=/usr/local/apache2/bin/apxs
My copy of neon was configured and installed by subversion revision 464.
I am having subversion build db "within the Subversion source tree".
What can I do to help shed some light onto this?
Sincerely,
Jay Freeman (saurik)
saurik@saurik.com
-----Original Message-----
From: Greg Stein [mailto:gstein@lyra.org]
Sent: Monday, November 19, 2001 12:46 AM
To: Jay Freeman (saurik)
Cc: svn-dev
Subject: Re: 'svn commit' fails with PROPPATCH error...
On Sat, Nov 17, 2001 at 05:29:26AM -0600, Jay Freeman (saurik) wrote:
>...
> [root(3)@dreadnought repos]# svn commit
>
> svn_error: #21075 : <RA layer's server request failed>
> The log message's PROPPATCH request failed (neon: 1)
> (/svn/repos/$svn/wbl/563007c8-d11d-b211-a84d-d794e2525663/0)
>
> I checked the web server's error_log, and got the following:
>
> [Sat Nov 17 02:55:00 2001] [error] [client 209.224.199.248] Could not
> execute PROPPATCH. [500, #206]
> [Sat Nov 17 02:55:00 2001] [error] [client 209.224.199.248] Properties
> may only be defined in the svn: and svn:custom: namespaces. [409, #0]
Bizarre. Never seen that one :-(
...
> I thought I'd at least try the latest copy before sending this e-mail,
> so I svn'd out the latest svn, compiled it, and apxs'd it. Now Apache
> won't even run :). I get:
...
Your Apache was compiled with AP_DEBUG and Subversion was compiled
without
debug. You'll need to rebuild one of the two. I'd recommend Subversion:
...
That should allow mod_dav_svn to load again, but I have no idea what's
going
on with the PROPPATCH problem. After rebuilding, please try again and
report
back if it keeps happening. We may be able to find out how that could
happen.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: 'svn commit' fails with PROPPATCH error...
Posted by Greg Stein <gs...@lyra.org>.
On Sat, Nov 17, 2001 at 05:29:26AM -0600, Jay Freeman (saurik) wrote:
>...
> [root(3)@dreadnought repos]# svn commit
>
> svn_error: #21075 : <RA layer's server request failed>
> The log message's PROPPATCH request failed (neon: 1)
> (/svn/repos/$svn/wbl/563007c8-d11d-b211-a84d-d794e2525663/0)
>
> I checked the web server's error_log, and got the following:
>
> [Sat Nov 17 02:55:00 2001] [error] [client 209.224.199.248] Could not
> execute PROPPATCH. [500, #206]
> [Sat Nov 17 02:55:00 2001] [error] [client 209.224.199.248] Properties
> may only be defined in the svn: and svn:custom: namespaces. [409, #0]
Bizarre. Never seen that one :-(
> I tried to chmod -R 777 /cvs/svn (as it was mentioned that many
> errors might occur due to permission problems), but that didn't help
> any. :(... confused...
No... that error isn't related to permissions at all. No idea how you were
able to get that one.
> I thought I'd at least try the latest copy before sending this e-mail,
> so I svn'd out the latest svn, compiled it, and apxs'd it. Now Apache
> won't even run :). I get:
>
> [root(3)@dreadnought mod_dav_svn]# /usr/local/apache2/bin/apachectl
> configtest
> Syntax error on line 198 of /usr/local/apache2/conf/httpd.conf:
> Cannot load /usr/local/apache2/modules/libmod_dav_svn.so into server:
> /usr/local/apache2/modules/libmod_dav_svn.so: undefined symbol:
> ap_get_module_config
Your Apache was compiled with AP_DEBUG and Subversion was compiled without
debug. You'll need to rebuild one of the two. I'd recommend Subversion:
$ ./config.nice --enable-maintainer-mode
$ make clean
$ make install
The config.nice script reruns configure with your previous switches and adds
the maintainer mode switch.
That should allow mod_dav_svn to load again, but I have no idea what's going
on with the PROPPATCH problem. After rebuilding, please try again and report
back if it keeps happening. We may be able to find out how that could
happen.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org