[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #6902: risc-v/mpfs: ihc: update vq ids

[GitBox <gi...@apache.org>]

eenurkka commented on code in PR #6902:
URL: https://github.com/apache/incubator-nuttx/pull/6902#discussion_r952548534


##########
arch/risc-v/src/mpfs/mpfs_ihc.c:
##########
@@ -965,11 +965,11 @@ mpfs_rptun_get_resource(struct rptun_dev_s *dev)
       rsc->rpmsg_vring0.align       = VRING_ALIGN;
       rsc->rpmsg_vring0.num         = VRING_NR;
       rsc->rpmsg_vring0.da          = VRING0_DESCRIPTORS;
-      rsc->rpmsg_vring0.notifyid    = 0;
+      rsc->rpmsg_vring0.notifyid    = 1;
       rsc->rpmsg_vring1.align       = VRING_ALIGN;
       rsc->rpmsg_vring1.num         = VRING_NR;
       rsc->rpmsg_vring1.da          = VRING1_DESCRIPTORS;
-      rsc->rpmsg_vring0.notifyid    = 1;
+      rsc->rpmsg_vring0.notifyid    = 0;

Review Comment:
   Should be rsc->rpmsg_vring1.notifyid    = 0;  (not vring0, apparent typo).. need to check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org