You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "runom (via GitHub)" <gi...@apache.org> on 2023/11/12 15:57:57 UTC
[PR] MINOR: Fix MetricsTest.testBrokerTopicMetricsBytesInOut assertion [kafka]
runom opened a new pull request, #14744:
URL: https://github.com/apache/kafka/pull/14744
This PR fixed the position of the assertion that checks that `BytesOut` doesn't include replication.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix MetricsTest.testBrokerTopicMetricsBytesInOut assertion [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #14744:
URL: https://github.com/apache/kafka/pull/14744#issuecomment-1951789085
Retriggering CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14744/4/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix MetricsTest.testBrokerTopicMetricsBytesInOut assertion [kafka]
Posted by "runom (via GitHub)" <gi...@apache.org>.
runom commented on PR #14744:
URL: https://github.com/apache/kafka/pull/14744#issuecomment-1819076742
The assertion position was changed by PR https://github.com/apache/kafka/pull/6977.
Hi @guozhangwang, could you take a look at my PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix MetricsTest.testBrokerTopicMetricsBytesInOut assertion [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14744:
URL: https://github.com/apache/kafka/pull/14744#issuecomment-1951633449
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix MetricsTest.testBrokerTopicMetricsBytesInOut assertion [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on PR #14744:
URL: https://github.com/apache/kafka/pull/14744#issuecomment-1953424263
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix MetricsTest.testBrokerTopicMetricsBytesInOut assertion [kafka]
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon merged PR #14744:
URL: https://github.com/apache/kafka/pull/14744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org